From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 4/4] regulator: tps62360: Provide settling time for voltage change
Date: Mon, 7 May 2012 15:51:27 +0100 [thread overview]
Message-ID: <20120507145126.GH17002@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FA7DFF9.5010606@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Mon, May 07, 2012 at 08:15:13PM +0530, Laxman Dewangan wrote:
> Actually I saw the multiple driver which uses
> set_bits()/clear_bits() and thought that this is good way of writing
> clean code and so developed multiple driver surrounding these apis.
> Now seems it is easy for me to use these apis. May be it is my
> personal taste.
It's a taste thing, a lot of those drivers are doing this because they
cloned the wm8350 driver (or something else which was based off the
wm8350 driver - it was the first of these).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-07 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 7:35 [PATCH V1 0/4] regulator: tps62360: add cache support and settling time Laxman Dewangan
2012-05-07 7:35 ` [PATCH V1 1/4] regmap: add function for set/clear bits Laxman Dewangan
2012-05-07 10:55 ` Mark Brown
2012-05-07 7:35 ` [PATCH V1 2/4] regulator: tps62360: enable register cache Laxman Dewangan
2012-05-07 11:13 ` Mark Brown
2012-05-07 7:35 ` [PATCH V1 3/4] regulator: tps62360: use efficient function Laxman Dewangan
2012-05-07 7:35 ` [PATCH V1 4/4] regulator: tps62360: Provide settling time for voltage change Laxman Dewangan
2012-05-07 11:23 ` Mark Brown
2012-05-07 12:42 ` Laxman Dewangan
2012-05-07 14:22 ` Mark Brown
2012-05-07 14:45 ` Laxman Dewangan
2012-05-07 14:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507145126.GH17002@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.