From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 4/4] regulator: tps62360: Provide settling time for voltage change
Date: Mon, 7 May 2012 18:12:04 +0530 [thread overview]
Message-ID: <4FA7C31C.7000309@nvidia.com> (raw)
In-Reply-To: <20120507112321.GI4415@opensource.wolfsonmicro.com>
On Monday 07 May 2012 04:53 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, May 07, 2012 at 01:05:39PM +0530, Laxman Dewangan wrote:
>> Settling time is require when there is voltage output change.
>> Implement set_voltage_time_sel() callback which returns delay time
>> for voltage change to settle down to new value.
> This is fine but depends on your previous stylistic change so won't
> apply. In general you should always try to order things so that there
> are fewer dependencies at the start of the series - there's no actual
> dependency between this and the stylistic changes you've made.
>
Thanks for quick review.
Yaah, I should put the stylistic change at end..
I will send next patch for enabling cache and settling time.
Will keep discussion on stylistic changes and so will remove that from
this series.
next prev parent reply other threads:[~2012-05-07 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 7:35 [PATCH V1 0/4] regulator: tps62360: add cache support and settling time Laxman Dewangan
2012-05-07 7:35 ` [PATCH V1 1/4] regmap: add function for set/clear bits Laxman Dewangan
2012-05-07 10:55 ` Mark Brown
2012-05-07 7:35 ` [PATCH V1 2/4] regulator: tps62360: enable register cache Laxman Dewangan
2012-05-07 11:13 ` Mark Brown
2012-05-07 7:35 ` [PATCH V1 3/4] regulator: tps62360: use efficient function Laxman Dewangan
2012-05-07 7:35 ` [PATCH V1 4/4] regulator: tps62360: Provide settling time for voltage change Laxman Dewangan
2012-05-07 11:23 ` Mark Brown
2012-05-07 12:42 ` Laxman Dewangan [this message]
2012-05-07 14:22 ` Mark Brown
2012-05-07 14:45 ` Laxman Dewangan
2012-05-07 14:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA7C31C.7000309@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.