From: Tony Lindgren <tony@atomide.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Hilman, Kevin" <khilman@ti.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 4/4] ARM: OMAP2+: CLEANUP: Add new config option for different DPLL features
Date: Tue, 8 May 2012 10:26:57 -0700 [thread overview]
Message-ID: <20120508172657.GY5088@atomide.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA1AF65@DBDE01.ent.ti.com>
* Hiremath, Vaibhav <hvaibhav@ti.com> [120508 10:28]:
> On Tue, May 08, 2012 at 21:42:12, Tony Lindgren wrote:
> > * Vaibhav Hiremath <hvaibhav@ti.com> [120508 08:10]:
> > > This patch cleans up dpll_data structure, making structure
> > > fields definition based on feature availability for given SoC,
> > > managed using Kconfig rules.
> > >
> > > SOC_HAS_DPLL_IDLE: idle state
> > > SOC_HAS_DPLL_RECAL: recalibration capability
> > > SOC_HAS_DPLL_DCO_SEL: dco selection
> > > SOC_HAS_DPLL_SDDIV: sigma-delta div factor
> > > SOC_HAS_DPLL_FREQSEL: frequency selection
> >
> > These too should be SOC_HAS_OMAPXYZ_DPLL_IDLE etc.
> >
>
> Thanks Tony, I will change the option accordingly.
> Do you have any further comments on this series? If, no, I will change the
> option name and submit immediately.
Thanks, looks OK to me otherwise.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 4/4] ARM: OMAP2+: CLEANUP: Add new config option for different DPLL features
Date: Tue, 8 May 2012 10:26:57 -0700 [thread overview]
Message-ID: <20120508172657.GY5088@atomide.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA1AF65@DBDE01.ent.ti.com>
* Hiremath, Vaibhav <hvaibhav@ti.com> [120508 10:28]:
> On Tue, May 08, 2012 at 21:42:12, Tony Lindgren wrote:
> > * Vaibhav Hiremath <hvaibhav@ti.com> [120508 08:10]:
> > > This patch cleans up dpll_data structure, making structure
> > > fields definition based on feature availability for given SoC,
> > > managed using Kconfig rules.
> > >
> > > SOC_HAS_DPLL_IDLE: idle state
> > > SOC_HAS_DPLL_RECAL: recalibration capability
> > > SOC_HAS_DPLL_DCO_SEL: dco selection
> > > SOC_HAS_DPLL_SDDIV: sigma-delta div factor
> > > SOC_HAS_DPLL_FREQSEL: frequency selection
> >
> > These too should be SOC_HAS_OMAPXYZ_DPLL_IDLE etc.
> >
>
> Thanks Tony, I will change the option accordingly.
> Do you have any further comments on this series? If, no, I will change the
> option name and submit immediately.
Thanks, looks OK to me otherwise.
Tony
next prev parent reply other threads:[~2012-05-08 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 15:02 [PATCH 0/4] ARM: OMAP2+: Cleanup series in order to remove ARCH_OMAPx dependency Vaibhav Hiremath
2012-05-08 15:02 ` Vaibhav Hiremath
2012-05-08 15:02 ` [PATCH 1/4] ARM: OMAP2+: CLEANUP: All OMAP2PLUS uses omap-device.o target so add one entry Vaibhav Hiremath
2012-05-08 15:02 ` Vaibhav Hiremath
2012-05-08 15:02 ` [PATCH 2/4] ARM: OMAP2+: CLEANUP: Move omap3 dpll ops to dpll3xxx.c Vaibhav Hiremath
2012-05-08 15:02 ` Vaibhav Hiremath
2012-05-08 15:02 ` [PATCH 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals Vaibhav Hiremath
2012-05-08 15:02 ` Vaibhav Hiremath
2012-05-08 16:11 ` Tony Lindgren
2012-05-08 16:11 ` Tony Lindgren
2012-05-08 15:02 ` [RFC PATCH 4/4] ARM: OMAP2+: CLEANUP: Add new config option for different DPLL features Vaibhav Hiremath
2012-05-08 15:02 ` Vaibhav Hiremath
2012-05-08 16:12 ` Tony Lindgren
2012-05-08 16:12 ` Tony Lindgren
2012-05-08 17:24 ` Hiremath, Vaibhav
2012-05-08 17:24 ` Hiremath, Vaibhav
2012-05-08 17:26 ` Tony Lindgren [this message]
2012-05-08 17:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508172657.GY5088@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=hvaibhav@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.