* [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record
@ 2012-05-10 6:27 joohi.rastogi
2012-05-10 15:48 ` Lucas De Marchi
[not found] ` <20120510124743.339acb16@vader>
0 siblings, 2 replies; 4+ messages in thread
From: joohi.rastogi @ 2012-05-10 6:27 UTC (permalink / raw)
To: User Name; +Cc: User Name2
From: Joohi Rastogi <joohi.rastogi@stericsson.com>
---
audio/avrcp.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/audio/avrcp.c b/audio/avrcp.c
index 1b35c3f..7ed1bbb 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -93,6 +93,7 @@
#define AVRCP_FEATURE_CATEGORY_2 0x0002
#define AVRCP_FEATURE_CATEGORY_3 0x0004
#define AVRCP_FEATURE_CATEGORY_4 0x0008
+#define AVRCP_FEATURE_PLAYER_SETTINGS 0x0010
enum battery_status {
BATTERY_STATUS_NORMAL = 0,
@@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void)
uint16_t lp = AVCTP_PSM;
uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 | AVRCP_FEATURE_CATEGORY_2
- | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4);
+ | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4
+ | AVRCP_FEATURE_PLAYER_SETTINGS);
record = sdp_record_alloc();
if (!record)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record
2012-05-10 6:27 [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record joohi.rastogi
@ 2012-05-10 15:48 ` Lucas De Marchi
[not found] ` <20120510124743.339acb16@vader>
1 sibling, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2012-05-10 15:48 UTC (permalink / raw)
To: joohi.rastogi; +Cc: User Name
On Thu, 10 May 2012 11:57:44 +0530
<joohi.rastogi@stericsson.com> wrote:
> From: Joohi Rastogi <joohi.rastogi@stericsson.com>
>
> ---
> audio/avrcp.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index 1b35c3f..7ed1bbb 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -93,6 +93,7 @@
> #define AVRCP_FEATURE_CATEGORY_2 0x0002
> #define AVRCP_FEATURE_CATEGORY_3 0x0004
> #define AVRCP_FEATURE_CATEGORY_4 0x0008
> +#define AVRCP_FEATURE_PLAYER_SETTINGS 0x0010
>
> enum battery_status {
> BATTERY_STATUS_NORMAL = 0,
> @@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void)
> uint16_t lp = AVCTP_PSM;
> uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
> uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 |
> AVRCP_FEATURE_CATEGORY_2
> - | AVRCP_FEATURE_CATEGORY_3 |
> AVRCP_FEATURE_CATEGORY_4);
> + | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4
> + | AVRCP_FEATURE_PLAYER_SETTINGS);
Ack, but I'm not sure about the coding style. I think the preferred way
to split lines is to put "|" in the line before (and indent past the
"(".
Lucas De Marchi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record
[not found] ` <20120510124743.339acb16@vader>
@ 2012-05-10 15:52 ` Lucas De Marchi
0 siblings, 0 replies; 4+ messages in thread
From: Lucas De Marchi @ 2012-05-10 15:52 UTC (permalink / raw)
To: joohi.rastogi; +Cc: User Name
On Thu, May 10, 2012 at 12:47 PM, Lucas De Marchi
<lucas.demarchi@profusion.mobi> wrote:
> On Thu, 10 May 2012 11:57:44 +0530
> <joohi.rastogi@stericsson.com> wrote:
>
>> From: Joohi Rastogi <joohi.rastogi@stericsson.com>
>>
>> ---
>> audio/avrcp.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/audio/avrcp.c b/audio/avrcp.c
>> index 1b35c3f..7ed1bbb 100644
>> --- a/audio/avrcp.c
>> +++ b/audio/avrcp.c
>> @@ -93,6 +93,7 @@
>> #define AVRCP_FEATURE_CATEGORY_2 0x0002
>> #define AVRCP_FEATURE_CATEGORY_3 0x0004
>> #define AVRCP_FEATURE_CATEGORY_4 0x0008
>> +#define AVRCP_FEATURE_PLAYER_SETTINGS 0x0010
>>
>> enum battery_status {
>> BATTERY_STATUS_NORMAL = 0,
>> @@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void)
>> uint16_t lp = AVCTP_PSM;
>> uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
>> uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 |
>> AVRCP_FEATURE_CATEGORY_2
>> - | AVRCP_FEATURE_CATEGORY_3 |
>> AVRCP_FEATURE_CATEGORY_4);
>> + | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4
>> + | AVRCP_FEATURE_PLAYER_SETTINGS);
>
> Ack, but I'm not sure about the coding style. I think the preferred way
> to split lines is to put
>
> I'm not sure
HUmn... sorry, for these incomplete emails. I had some problems with
my email client.
Lucas De Marchi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record
@ 2012-05-18 5:39 joohi.rastogi
0 siblings, 0 replies; 4+ messages in thread
From: joohi.rastogi @ 2012-05-18 5:39 UTC (permalink / raw)
To: User Name; +Cc: User Name2
From: Joohi Rastogi <joohi.rastogi@stericsson.com>
---
audio/avrcp.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/audio/avrcp.c b/audio/avrcp.c
index a741873..00edcf3 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -93,6 +93,7 @@
#define AVRCP_FEATURE_CATEGORY_2 0x0002
#define AVRCP_FEATURE_CATEGORY_3 0x0004
#define AVRCP_FEATURE_CATEGORY_4 0x0008
+#define AVRCP_FEATURE_PLAYER_SETTINGS 0x0010
enum battery_status {
BATTERY_STATUS_NORMAL = 0,
@@ -251,7 +252,8 @@ static sdp_record_t *avrcp_tg_record(void)
uint16_t feat = ( AVRCP_FEATURE_CATEGORY_1 |
AVRCP_FEATURE_CATEGORY_2 |
AVRCP_FEATURE_CATEGORY_3 |
- AVRCP_FEATURE_CATEGORY_4 );
+ AVRCP_FEATURE_CATEGORY_4 |
+ AVRCP_FEATURE_PLAYER_SETTINGS );
record = sdp_record_alloc();
if (!record)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-18 5:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-10 6:27 [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record joohi.rastogi
2012-05-10 15:48 ` Lucas De Marchi
[not found] ` <20120510124743.339acb16@vader>
2012-05-10 15:52 ` Lucas De Marchi
-- strict thread matches above, loose matches on Subject: below --
2012-05-18 5:39 joohi.rastogi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.