All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH-V2] ARM: OMAP2+: am33xx: Make am33xx as a separate class
Date: Thu, 10 May 2012 11:05:36 -0700	[thread overview]
Message-ID: <20120510180535.GG21851@atomide.com> (raw)
In-Reply-To: <20120510180159.GF21851@atomide.com>

* Tony Lindgren <tony@atomide.com> [120510 11:06]:
> * Tony Lindgren <tony@atomide.com> [120509 11:58]:
> > * Vaibhav Hiremath <hvaibhav@ti.com> [120509 04:28]:
> > > Initially, we decided to make am33xx family of device to fall
> > > under omap3 class (cpu_is_omap34xx() = true), since it carries
> > > Cortex-A8 core. But while adding complete baseport support
> > > (like, clock, power and hwmod) support, it is observed that,
> > > we are creating more and more problems by treating am33xx device
> > > as omap3 family, as nothing matches between them
> > > (except cortex-A8 mpu).
> > 
> > Thanks applying into devel-soc after updating for soc_is change
> > and fixing typo in the description that stil said OMAPAM. Updated
> > patch below.
> 
> Turns out we still need to add defined(CONFIG_SOC_AM33XX) around
> __omap2_set_globals() to keep compile working when omap4 + am33xx
> are selected without omap2 or 3. Also removed the "default y"
> for am33xx as that's where we're heading to anyways.
> 
> Updated patch below.

Argh, now it breaks with:

arch/arm/mach-omap2/built-in.o: In function `omap2_set_globals_am33xx':
twl-common.c:(.init.text+0x1dd8): undefined reference to `omap2_set_globals_sdrc'

There are clearly some dependencies to the clean up patches being
discussed.. So I'll drop this for now until the clean up is sorted
out.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V2] ARM: OMAP2+: am33xx: Make am33xx as a separate class
Date: Thu, 10 May 2012 11:05:36 -0700	[thread overview]
Message-ID: <20120510180535.GG21851@atomide.com> (raw)
In-Reply-To: <20120510180159.GF21851@atomide.com>

* Tony Lindgren <tony@atomide.com> [120510 11:06]:
> * Tony Lindgren <tony@atomide.com> [120509 11:58]:
> > * Vaibhav Hiremath <hvaibhav@ti.com> [120509 04:28]:
> > > Initially, we decided to make am33xx family of device to fall
> > > under omap3 class (cpu_is_omap34xx() = true), since it carries
> > > Cortex-A8 core. But while adding complete baseport support
> > > (like, clock, power and hwmod) support, it is observed that,
> > > we are creating more and more problems by treating am33xx device
> > > as omap3 family, as nothing matches between them
> > > (except cortex-A8 mpu).
> > 
> > Thanks applying into devel-soc after updating for soc_is change
> > and fixing typo in the description that stil said OMAPAM. Updated
> > patch below.
> 
> Turns out we still need to add defined(CONFIG_SOC_AM33XX) around
> __omap2_set_globals() to keep compile working when omap4 + am33xx
> are selected without omap2 or 3. Also removed the "default y"
> for am33xx as that's where we're heading to anyways.
> 
> Updated patch below.

Argh, now it breaks with:

arch/arm/mach-omap2/built-in.o: In function `omap2_set_globals_am33xx':
twl-common.c:(.init.text+0x1dd8): undefined reference to `omap2_set_globals_sdrc'

There are clearly some dependencies to the clean up patches being
discussed.. So I'll drop this for now until the clean up is sorted
out.

Regards,

Tony

  reply	other threads:[~2012-05-10 18:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 11:24 [PATCH-V2] ARM: OMAP2+: am33xx: Make am33xx as a separate class Vaibhav Hiremath
2012-05-09 11:24 ` Vaibhav Hiremath
2012-05-09 18:54 ` Tony Lindgren
2012-05-09 18:54   ` Tony Lindgren
2012-05-10 18:01   ` Tony Lindgren
2012-05-10 18:01     ` Tony Lindgren
2012-05-10 18:05     ` Tony Lindgren [this message]
2012-05-10 18:05       ` Tony Lindgren
2012-05-10 18:18       ` Hiremath, Vaibhav
2012-05-10 18:18         ` Hiremath, Vaibhav
2012-05-10 18:30         ` Tony Lindgren
2012-05-10 18:30           ` Tony Lindgren
2012-05-10 18:37           ` Hiremath, Vaibhav
2012-05-10 18:37             ` Hiremath, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120510180535.GG21851@atomide.com \
    --to=tony@atomide.com \
    --cc=hvaibhav@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.