From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: dmitry.torokhov@gmail.com, peter.ujfalusi@ti.com,
broonie@opensource.wolfsonicro.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TWL6040: fix build error
Date: Thu, 10 May 2012 22:58:06 -0400 [thread overview]
Message-ID: <20120511025806.GB24512@windriver.com> (raw)
In-Reply-To: <CA+1xoqf+Fjt=vMxnFz37t+mH5MBfc7iTZ0OF2fQdryyWk5TSKA@mail.gmail.com>
[Re: [PATCH] TWL6040: fix build error] On 11/05/2012 (Fri 04:50) Sasha Levin wrote:
> On Fri, May 11, 2012 at 12:49 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> >
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware. I'm guessing limiting to ARM would be a good start?
>
> I'm not sure how the actual hardware looks or even what it does, i
> just wanted to make sure that it doesn't break my x86 build. Which is
> why I'd rather not modify anything further than what I did in this
> patch.
Of course -- I was in the same boat. I wasn't expecting you in
particular to add the Kconfig dependency, but rather instead I was
hoping someone who knows the platform details would make a proper one.
Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: <dmitry.torokhov@gmail.com>, <peter.ujfalusi@ti.com>,
<broonie@opensource.wolfsonicro.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] TWL6040: fix build error
Date: Thu, 10 May 2012 22:58:06 -0400 [thread overview]
Message-ID: <20120511025806.GB24512@windriver.com> (raw)
In-Reply-To: <CA+1xoqf+Fjt=vMxnFz37t+mH5MBfc7iTZ0OF2fQdryyWk5TSKA@mail.gmail.com>
[Re: [PATCH] TWL6040: fix build error] On 11/05/2012 (Fri 04:50) Sasha Levin wrote:
> On Fri, May 11, 2012 at 12:49 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> >
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware. I'm guessing limiting to ARM would be a good start?
>
> I'm not sure how the actual hardware looks or even what it does, i
> just wanted to make sure that it doesn't break my x86 build. Which is
> why I'd rather not modify anything further than what I did in this
> patch.
Of course -- I was in the same boat. I wasn't expecting you in
particular to add the Kconfig dependency, but rather instead I was
hoping someone who knows the platform details would make a proper one.
Paul.
next prev parent reply other threads:[~2012-05-11 2:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 18:44 [PATCH] TWL6040: fix build error Sasha Levin
2012-05-10 22:49 ` Paul Gortmaker
2012-05-10 22:49 ` Paul Gortmaker
2012-05-11 2:50 ` Sasha Levin
2012-05-11 2:50 ` Sasha Levin
2012-05-11 2:58 ` Paul Gortmaker [this message]
2012-05-11 2:58 ` Paul Gortmaker
2012-05-11 4:27 ` Grant Likely
2012-05-11 4:27 ` Grant Likely
2012-05-11 12:16 ` Peter Ujfalusi
2012-05-11 12:16 ` Peter Ujfalusi
2012-05-11 7:03 ` Peter Ujfalusi
2012-05-11 7:03 ` Peter Ujfalusi
2012-05-11 7:20 ` Dmitry Torokhov
2012-05-11 14:03 ` Paul Gortmaker
2012-05-11 14:03 ` Paul Gortmaker
2012-05-11 15:05 ` Peter Ujfalusi
2012-05-11 15:05 ` Peter Ujfalusi
2012-05-11 15:49 ` Dmitry Torokhov
2012-05-11 16:10 ` Paul Gortmaker
2012-05-11 16:10 ` Paul Gortmaker
2012-05-13 10:53 ` Mark Brown
2012-05-11 4:03 ` Dmitry Torokhov
2012-05-11 6:58 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511025806.GB24512@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=broonie@opensource.wolfsonicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=levinsasha928@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.