All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>
Subject: Re: [PATCH] ARM: OMAP1: USB: fix ocpi_enable compile problem on non-1610 builds
Date: Fri, 11 May 2012 09:53:07 -0700	[thread overview]
Message-ID: <20120511165306.GT21851@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205101625360.32719@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [120510 15:31]:
> 
> Janusz Krzysztofik reported the following build break on OMAP1 builds that
> don't include CONFIG_ARCH_OMAP16XX:
> 
>   LD      .tmp_vmlinux1
> arch/arm/mach-omap1/built-in.o: In function `omap1_usb_init':
> lcd_dma.c:(.init.text+0x1420): undefined reference to `ocpi_enable'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This was caused by commit d3645d39ad0ed9f09535065676ea0ba114f93cdf
> ("ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus").
> Fix by declaring an empty ocpi_enable() on non-16XX builds, which
> should work until the OCPI code is moved out to drivers/.

Thanks applying into fixes-for-cleanup branch.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP1: USB: fix ocpi_enable compile problem on non-1610 builds
Date: Fri, 11 May 2012 09:53:07 -0700	[thread overview]
Message-ID: <20120511165306.GT21851@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205101625360.32719@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [120510 15:31]:
> 
> Janusz Krzysztofik reported the following build break on OMAP1 builds that
> don't include CONFIG_ARCH_OMAP16XX:
> 
>   LD      .tmp_vmlinux1
> arch/arm/mach-omap1/built-in.o: In function `omap1_usb_init':
> lcd_dma.c:(.init.text+0x1420): undefined reference to `ocpi_enable'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This was caused by commit d3645d39ad0ed9f09535065676ea0ba114f93cdf
> ("ARM: OMAP1: OHCI: use platform_data fn ptr to enable OCPI bus").
> Fix by declaring an empty ocpi_enable() on non-16XX builds, which
> should work until the OCPI code is moved out to drivers/.

Thanks applying into fixes-for-cleanup branch.

Tony

  reply	other threads:[~2012-05-11 16:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 22:27 [PATCH] ARM: OMAP1: USB: fix ocpi_enable compile problem on non-1610 builds Paul Walmsley
2012-05-10 22:27 ` Paul Walmsley
2012-05-11 16:53 ` Tony Lindgren [this message]
2012-05-11 16:53   ` Tony Lindgren
2012-05-14 13:51   ` Janusz Krzysztofik
2012-05-14 13:51     ` Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511165306.GT21851@atomide.com \
    --to=tony@atomide.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.