From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: OTG integration: fix compiler warning
Date: Fri, 11 May 2012 09:57:48 -0700 [thread overview]
Message-ID: <20120511165748.GU21851@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205091637100.23869@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [120509 15:41]:
>
> Tony reported the following compile warning after commit
> eeb3711b89d68e147e05e7b43a49ecc5009dc157 ("ARM: OMAP2+: clean up some
> cppcheck warnings"):
>
> arch/arm/plat-omap/usb.c: In function 'omap_otg_init':
> arch/arm/plat-omap/usb.c:40: warning: unused variable 'status'
>
> This happens if CONFIG_ARCH_OMAP_OTG is set but
> CONFIG_USB_GADGET_OMAP, CONFIG_USB_OHCI_HCD,
> CONFIG_USB_OHCI_HCD_MODULE, and CONFIG_USB_OTG are all unset.
>
> Fix by localizing the status variable to the blocks that use it.
>
> Compile-tested only, with omap2plus_defconfig and omap2plus_defconfig
> with CONFIG_USB_OHCI_HCD and CONFIG_USB_OTG enabled.
Thanks applying into fixes-for-cleanup branch.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: OTG integration: fix compiler warning
Date: Fri, 11 May 2012 09:57:48 -0700 [thread overview]
Message-ID: <20120511165748.GU21851@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205091637100.23869@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [120509 15:41]:
>
> Tony reported the following compile warning after commit
> eeb3711b89d68e147e05e7b43a49ecc5009dc157 ("ARM: OMAP2+: clean up some
> cppcheck warnings"):
>
> arch/arm/plat-omap/usb.c: In function 'omap_otg_init':
> arch/arm/plat-omap/usb.c:40: warning: unused variable 'status'
>
> This happens if CONFIG_ARCH_OMAP_OTG is set but
> CONFIG_USB_GADGET_OMAP, CONFIG_USB_OHCI_HCD,
> CONFIG_USB_OHCI_HCD_MODULE, and CONFIG_USB_OTG are all unset.
>
> Fix by localizing the status variable to the blocks that use it.
>
> Compile-tested only, with omap2plus_defconfig and omap2plus_defconfig
> with CONFIG_USB_OHCI_HCD and CONFIG_USB_OTG enabled.
Thanks applying into fixes-for-cleanup branch.
Tony
next prev parent reply other threads:[~2012-05-11 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:38 [PATCH] ARM: OMAP: OTG integration: fix compiler warning Paul Walmsley
2012-05-09 22:38 ` Paul Walmsley
2012-05-11 16:57 ` Tony Lindgren [this message]
2012-05-11 16:57 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511165748.GU21851@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.