From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5
Date: Fri, 11 May 2012 13:00:55 -0600 [thread overview]
Message-ID: <20120511190055.4ED363E0791@localhost> (raw)
In-Reply-To: <4F846C53.1070407@samsung.com>
On Tue, 10 Apr 2012 10:22:27 -0700, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Olof Johansson wrote:
> > Only code move, no functional change.
> >
> > Main reason to do this was to get rid of the warnings:
> >
> > drivers/gpio/gpio-samsung.c: In function 'samsung_gpiolib_init':
> > drivers/gpio/gpio-samsung.c:2974:1: warning: label 'err_ioremap4' defined but not used [-Wunused-label]
> > drivers/gpio/gpio-samsung.c:2722:47: warning: unused variable 'gpio_base4' [-Wunused-variable]
> >
> > without adding more ifdef mess.
> >
> > I think this whole file would do well being coverted over to a platform
> > driver and moving most of the tables out to SoC code and/or device trees,
> > but since that changes init ordering it needs to be done with some care,
> > i.e. not at this time.
> >
> > Signed-off-by: Olof Johansson<olof@lixom.net>
>
> Looks ok to me :)
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Applied, thanks.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Kukjin Kim <kgene.kim@samsung.com>, Olof Johansson <olof@lixom.net>
Cc: kgene.kim@samsung.com, linus.walleij@stericsson.com,
sangsu4u.park@samsung.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5
Date: Fri, 11 May 2012 13:00:55 -0600 [thread overview]
Message-ID: <20120511190055.4ED363E0791@localhost> (raw)
In-Reply-To: <4F846C53.1070407@samsung.com>
On Tue, 10 Apr 2012 10:22:27 -0700, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Olof Johansson wrote:
> > Only code move, no functional change.
> >
> > Main reason to do this was to get rid of the warnings:
> >
> > drivers/gpio/gpio-samsung.c: In function 'samsung_gpiolib_init':
> > drivers/gpio/gpio-samsung.c:2974:1: warning: label 'err_ioremap4' defined but not used [-Wunused-label]
> > drivers/gpio/gpio-samsung.c:2722:47: warning: unused variable 'gpio_base4' [-Wunused-variable]
> >
> > without adding more ifdef mess.
> >
> > I think this whole file would do well being coverted over to a platform
> > driver and moving most of the tables out to SoC code and/or device trees,
> > but since that changes init ordering it needs to be done with some care,
> > i.e. not at this time.
> >
> > Signed-off-by: Olof Johansson<olof@lixom.net>
>
> Looks ok to me :)
>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Applied, thanks.
g.
next prev parent reply other threads:[~2012-05-11 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 19:23 [PATCH] gpio: samsung: refactor gpiolib init for exynos4/5 Olof Johansson
2012-04-08 19:23 ` Olof Johansson
2012-04-10 17:22 ` Kukjin Kim
2012-04-10 17:22 ` Kukjin Kim
2012-05-11 19:00 ` Grant Likely [this message]
2012-05-11 19:00 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511190055.4ED363E0791@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.