Re: [PATCH v4 2/5] hwmon: exynos4: Move thermal sensor driver to driver/thermal directory

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Sat, May 12, 2012 at 05:40:42AM -0400, Amit Daniel Kachhap wrote:
> This movement is needed because the hwmon entries and corresponding
> sysfs interface is a duplicate of utilities already provided by
> driver/thermal/thermal_sys.c. The goal is to place it in thermal folder
> and add necessary functions to use the in-kernel thermal interfaces.
> 
> CC: Guenter Roeck <guenter.roeck@ericsson.com>
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@linaro.org>
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>

Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>

Some suggestions, possibly for later cleanup.

> -
> -       data = kzalloc(sizeof(struct exynos4_tmu_data), GFP_KERNEL);

If you use devm_kzalloc, you won't have to free it.

[ ...]

> -       data->mem = request_mem_region(data->mem->start,
> -                       resource_size(data->mem), pdev->name);

Same here, with devm_request_mem_region.

[ ... ]

> -       data->base = ioremap(data->mem->start, resource_size(data->mem));

and devm_ioremap

[ ... ]

> -       ret = request_irq(data->irq, exynos4_tmu_irq,

and devm_request_irq

Guenter