From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mfd: anatop: permit adata be NULL when access register
Date: Mon, 14 May 2012 09:08:36 +0100 [thread overview]
Message-ID: <20120514080835.GB31985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120514035137.GB20367@S2100-06.ap.freescale.net>
On Mon, May 14, 2012 at 11:51:38AM +0800, Shawn Guo wrote:
> From what I see, it's reasonable. Then the immediate question I have
> is, should we remove "struct anatop *adata" from anatop_read_reg and
> anatop_write_reg completely?
Given the way these things tend to go it's probably guaranteeing that
your next round of SoCs will have two register compatible anatop blocks :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120514/f89fb098/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Richard Zhao <richard.zhao@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, paul.liu@linaro.org,
Richard Zhao <richard.zhao@freescale.com>,
sameo@linux.intel.com, shawn.guo@linaro.org
Subject: Re: [PATCH 2/2] mfd: anatop: permit adata be NULL when access register
Date: Mon, 14 May 2012 09:08:36 +0100 [thread overview]
Message-ID: <20120514080835.GB31985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120514035137.GB20367@S2100-06.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Mon, May 14, 2012 at 11:51:38AM +0800, Shawn Guo wrote:
> From what I see, it's reasonable. Then the immediate question I have
> is, should we remove "struct anatop *adata" from anatop_read_reg and
> anatop_write_reg completely?
Given the way these things tend to go it's probably guaranteeing that
your next round of SoCs will have two register compatible anatop blocks :)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-14 8:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 0:59 [PATCH 1/2] mfd: anatop: make register accessor more flexible and rename meaningfully Richard Zhao
2012-05-13 0:59 ` Richard Zhao
2012-05-13 0:59 ` [PATCH 2/2] mfd: anatop: permit adata be NULL when access register Richard Zhao
2012-05-13 0:59 ` Richard Zhao
2012-05-14 3:51 ` Shawn Guo
2012-05-14 3:51 ` Shawn Guo
2012-05-14 8:08 ` Mark Brown [this message]
2012-05-14 8:08 ` Mark Brown
2012-05-14 8:48 ` Shawn Guo
2012-05-14 8:48 ` Shawn Guo
2012-05-14 9:01 ` Ying-Chun Liu (PaulLiu)
2012-05-14 9:01 ` Ying-Chun Liu (PaulLiu)
2012-05-14 9:43 ` Shawn Guo
2012-05-14 9:43 ` Shawn Guo
2012-05-14 13:26 ` Ying-Chun Liu (PaulLiu)
2012-05-14 13:26 ` Ying-Chun Liu (PaulLiu)
2012-05-14 13:50 ` Richard Zhao
2012-05-14 13:50 ` Richard Zhao
2012-05-18 9:59 ` Richard Zhao
2012-05-18 9:59 ` Richard Zhao
2012-05-21 4:13 ` Shawn Guo
2012-05-21 4:13 ` Shawn Guo
2012-05-21 9:27 ` Ying-Chun Liu (PaulLiu)
2012-05-21 9:27 ` Ying-Chun Liu (PaulLiu)
2012-05-21 9:39 ` Richard Zhao
2012-05-21 9:39 ` Richard Zhao
2012-06-18 20:23 ` Rob Lee
2012-06-18 20:23 ` Rob Lee
2012-06-18 21:58 ` Samuel Ortiz
2012-06-18 21:58 ` Samuel Ortiz
2012-06-18 22:59 ` Rob Lee
2012-06-18 22:59 ` Rob Lee
2012-05-13 1:18 ` [PATCH V2] mfd: anatop: make register accessor more flexible and rename meaningfully Richard Zhao
2012-05-13 1:18 ` Richard Zhao
2012-05-13 17:48 ` Ying-Chun Liu (PaulLiu)
2012-05-13 17:48 ` Ying-Chun Liu (PaulLiu)
2012-05-18 9:09 ` Samuel Ortiz
2012-05-18 9:09 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514080835.GB31985@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.