From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings
Date: Mon, 14 May 2012 15:26:28 +0300 [thread overview]
Message-ID: <20120514122628.GH16984@mwanda> (raw)
In-Reply-To: <1336992089-2733-2-git-send-email-siglesias@igalia.com>
On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
> /* Read status register */
> - status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> + status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
> TPCI200_STATUS_REG));
>
Later in the patch, you do the right thing which is to declare this
as an __iomem pointer in the header. The cast here can be removed
and it all fits on one line.
Remove it in a follow on patch if you want. Same for several of the
other casts in this patch.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-14 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 10:41 [PATCH 0/5] Staging ipack: device model and clean-up Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 1/5] Staging ipack: fix a few sparse warnings Samuel Iglesias Gonsalvez
2012-05-14 12:26 ` Dan Carpenter [this message]
2012-05-14 12:53 ` Samuel Iglesias Gonsálvez
2012-05-14 10:41 ` [PATCH 2/5] Staging: ipack: add proper device model into ipack_bus_register Samuel Iglesias Gonsalvez
2012-05-14 20:46 ` Greg Kroah-Hartman
2012-05-15 14:11 ` Samuel Iglesias Gonsálvez
2012-05-15 15:13 ` Samuel Iglesias Gonsálvez
2012-05-14 10:41 ` [PATCH 3/5] Staging: ipack: remove board_name and bus_name fields from struct ipack_device Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 4/5] Staging ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 5/5] Staging: ipack/devices/ipoctal: check for availability of helper functions in ipoctal_match() Samuel Iglesias Gonsalvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514122628.GH16984@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.