From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] Staging: ipack: add proper device model into ipack_bus_register.
Date: Mon, 14 May 2012 13:46:54 -0700 [thread overview]
Message-ID: <20120514204654.GA8723@kroah.com> (raw)
In-Reply-To: <1336992089-2733-3-git-send-email-siglesias@igalia.com>
On Mon, May 14, 2012 at 12:41:26PM +0200, Samuel Iglesias Gonsalvez wrote:
> This patch adds a proper device model to the driver. The carrier boards are
> managed like other ipack device, the way to recognize them is using the
> platform data field from struct device.
Wait, what? Why would you use the platform data field? Why is that
needed at all? You can specify the "type" of the device, but it seems
that you really want two different things here, busses and devices,
right? So use two different devices and manage them differently, don't
make them the "same but different" by looking at the platform data
field. That's not what the platform data field is for at all, sorry.
Please rework this patch, I can't take it as-is, sorry.
greg k-h
next prev parent reply other threads:[~2012-05-14 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 10:41 [PATCH 0/5] Staging ipack: device model and clean-up Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 1/5] Staging ipack: fix a few sparse warnings Samuel Iglesias Gonsalvez
2012-05-14 12:26 ` Dan Carpenter
2012-05-14 12:53 ` Samuel Iglesias Gonsálvez
2012-05-14 10:41 ` [PATCH 2/5] Staging: ipack: add proper device model into ipack_bus_register Samuel Iglesias Gonsalvez
2012-05-14 20:46 ` Greg Kroah-Hartman [this message]
2012-05-15 14:11 ` Samuel Iglesias Gonsálvez
2012-05-15 15:13 ` Samuel Iglesias Gonsálvez
2012-05-14 10:41 ` [PATCH 3/5] Staging: ipack: remove board_name and bus_name fields from struct ipack_device Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 4/5] Staging ipack/bridges/tpci200: remove TPCI200_SHORTNAME constant Samuel Iglesias Gonsalvez
2012-05-14 10:41 ` [PATCH 5/5] Staging: ipack/devices/ipoctal: check for availability of helper functions in ipoctal_match() Samuel Iglesias Gonsalvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514204654.GA8723@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.