All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL][Update] Renesas ARM-based platforms: new boards support for v3.5
Date: Tue, 15 May 2012 15:30:17 +0000	[thread overview]
Message-ID: <201205151530.18193.arnd@arndb.de> (raw)
In-Reply-To: <201205150840.23283.arnd@arndb.de>

On Tuesday 15 May 2012, Arnd Bergmann wrote:
> On Monday 14 May 2012, Rafael J. Wysocki wrote:
> > Please pull changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3
> > 
> >     Linux 3.4-rc6
> > 
> > with top-most commit 4fc5e65cdbf736a5311b07aa54a916ccaa91ab5f
> > 
> >     Merge branch 'renesas-kzm9g' into renesas-board-new
> > 
> > from the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rafael/renesas.git board-new
> > 
> > to receive updates of the Renesas ARM-based boards support code for v3.5.
> > Included are:
> > 
> >  * Support for the KZM-A9-GT board from Kuninori Morimoto and Magnus Damm.
> > 
> >  * Support for the armadillo800eva board from Kuninori Morimoto and Magnus Damm.
> > 
> > This is based on the Renesas core SoC code updates I've sent a separate pull
> > request for.

I got build errors with the new version now because machine_is_kzm9g is no longer
defined:

/home/arnd/linux-arm/arch/arm/mach-shmobile/platsmp.c: In function 'shmobile_smp_get_core_count':
/home/arnd/linux-arm/arch/arm/mach-shmobile/platsmp.c:29:2: error: implicit declaration of function 'of_machine_is_compatible' [-Werror=implicit-function-declaration]

I'd apply the patch below, unless someone has a better solution

	Arnd

diff --git a/arch/arm/boot/dts/sh73a0-kzm9g.dts b/arch/arm/boot/dts/sh73a0-kzm9g.dts
index ed1bae5..bcb9119 100644
--- a/arch/arm/boot/dts/sh73a0-kzm9g.dts
+++ b/arch/arm/boot/dts/sh73a0-kzm9g.dts
@@ -13,7 +13,7 @@
 
 / {
 	model = "KZM-A9-GT";
-	compatible = "renesas,kzm9g";
+	compatible = "renesas,kzm9g", "renesas,sh73a0";
 
 	memory {
 		device_type = "memory";
diff --git a/arch/arm/mach-shmobile/platsmp.c b/arch/arm/mach-shmobile/platsmp.c
index d959f07..2946214 100644
--- a/arch/arm/mach-shmobile/platsmp.c
+++ b/arch/arm/mach-shmobile/platsmp.c
@@ -20,7 +20,8 @@
 #include <asm/mach-types.h>
 #include <mach/common.h>
 
-#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2() || machine_is_kzm9g())
+#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2() || \
+			of_machine_is_compatible("renesas,sh73a0"))
 #define is_r8a7779() machine_is_marzen()
 
 static unsigned int __init shmobile_smp_get_core_count(void)

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL][Update] Renesas ARM-based platforms: new boards support for v3.5
Date: Tue, 15 May 2012 15:30:17 +0000	[thread overview]
Message-ID: <201205151530.18193.arnd@arndb.de> (raw)
In-Reply-To: <201205150840.23283.arnd@arndb.de>

On Tuesday 15 May 2012, Arnd Bergmann wrote:
> On Monday 14 May 2012, Rafael J. Wysocki wrote:
> > Please pull changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3
> > 
> >     Linux 3.4-rc6
> > 
> > with top-most commit 4fc5e65cdbf736a5311b07aa54a916ccaa91ab5f
> > 
> >     Merge branch 'renesas-kzm9g' into renesas-board-new
> > 
> > from the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rafael/renesas.git board-new
> > 
> > to receive updates of the Renesas ARM-based boards support code for v3.5.
> > Included are:
> > 
> >  * Support for the KZM-A9-GT board from Kuninori Morimoto and Magnus Damm.
> > 
> >  * Support for the armadillo800eva board from Kuninori Morimoto and Magnus Damm.
> > 
> > This is based on the Renesas core SoC code updates I've sent a separate pull
> > request for.

I got build errors with the new version now because machine_is_kzm9g is no longer
defined:

/home/arnd/linux-arm/arch/arm/mach-shmobile/platsmp.c: In function 'shmobile_smp_get_core_count':
/home/arnd/linux-arm/arch/arm/mach-shmobile/platsmp.c:29:2: error: implicit declaration of function 'of_machine_is_compatible' [-Werror=implicit-function-declaration]

I'd apply the patch below, unless someone has a better solution

	Arnd

diff --git a/arch/arm/boot/dts/sh73a0-kzm9g.dts b/arch/arm/boot/dts/sh73a0-kzm9g.dts
index ed1bae5..bcb9119 100644
--- a/arch/arm/boot/dts/sh73a0-kzm9g.dts
+++ b/arch/arm/boot/dts/sh73a0-kzm9g.dts
@@ -13,7 +13,7 @@
 
 / {
 	model = "KZM-A9-GT";
-	compatible = "renesas,kzm9g";
+	compatible = "renesas,kzm9g", "renesas,sh73a0";
 
 	memory {
 		device_type = "memory";
diff --git a/arch/arm/mach-shmobile/platsmp.c b/arch/arm/mach-shmobile/platsmp.c
index d959f07..2946214 100644
--- a/arch/arm/mach-shmobile/platsmp.c
+++ b/arch/arm/mach-shmobile/platsmp.c
@@ -20,7 +20,8 @@
 #include <asm/mach-types.h>
 #include <mach/common.h>
 
-#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2() || machine_is_kzm9g())
+#define is_sh73a0() (machine_is_ag5evm() || machine_is_kota2() || \
+			of_machine_is_compatible("renesas,sh73a0"))
 #define is_r8a7779() machine_is_marzen()
 
 static unsigned int __init shmobile_smp_get_core_count(void)

  reply	other threads:[~2012-05-15 15:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 18:59 [GIT PULL] Renesas ARM-based platforms updates for v3.5 Rafael J. Wysocki
2012-05-11 19:01 ` Rafael J. Wysocki
2012-05-12  5:29 ` Olof Johansson
2012-05-12  5:29   ` Olof Johansson
2012-05-12 19:58   ` Rafael J. Wysocki
2012-05-12 19:58     ` Rafael J. Wysocki
2012-05-12 20:17     ` Rafael J. Wysocki
2012-05-12 20:17       ` Rafael J. Wysocki
2012-05-12 23:04     ` Olof Johansson
2012-05-12 23:04       ` Olof Johansson
2012-05-12 21:07   ` [GIT PULL] Renesas ARM-based platforms: core SoC " Rafael J. Wysocki
2012-05-12 21:18     ` [GIT PULL] Renesas ARM-based platforms: board support " Rafael J. Wysocki
2012-05-13  4:24       ` Olof Johansson
2012-05-13  4:24         ` Olof Johansson
2012-05-12 21:23     ` [GIT PULL] Renesas ARM-based platforms: new boards support " Rafael J. Wysocki
2012-05-13  6:29       ` Olof Johansson
2012-05-13  6:29         ` Olof Johansson
2012-05-14  7:13         ` Magnus Damm
2012-05-14  7:13           ` Magnus Damm
2012-05-15 19:58           ` Arnd Bergmann
2012-05-15 19:58             ` Arnd Bergmann
2012-05-16  6:17             ` Olof Johansson
2012-05-16  6:17               ` Olof Johansson
2012-05-14 21:43       ` [GIT PULL][Update] " Rafael J. Wysocki
2012-05-15  8:40         ` Arnd Bergmann
2012-05-15  8:40           ` Arnd Bergmann
2012-05-15 15:30           ` Arnd Bergmann [this message]
2012-05-15 15:30             ` Arnd Bergmann
2012-05-15 15:49             ` Rafael J. Wysocki
2012-05-15 15:49               ` Rafael J. Wysocki
2012-05-15 20:03               ` Arnd Bergmann
2012-05-15 20:03                 ` Arnd Bergmann
2012-05-15 15:50           ` Rafael J. Wysocki
2012-05-15 15:50             ` Rafael J. Wysocki
2012-05-12 23:29     ` [GIT PULL] Renesas ARM-based platforms: core SoC updates " Olof Johansson
2012-05-12 23:29       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205151530.18193.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.