From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Corbin Atkinson <corbinat@gmail.com>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org,
Corbin Atkinson <corbin.atkinson@ni.com>
Subject: Re: [PATCH 1/1] serial_core: Update buffer overrun statistics.
Date: Tue, 15 May 2012 08:58:33 -0700 [thread overview]
Message-ID: <20120515155833.GA24878@kroah.com> (raw)
In-Reply-To: <20120515165339.6b142cd2@pyramind.ukuu.org.uk>
On Tue, May 15, 2012 at 04:53:39PM +0100, Alan Cox wrote:
> On Fri, 4 May 2012 12:35:10 -0500
> Corbin Atkinson <corbinat@gmail.com> wrote:
>
> > Currently, serial drivers don't report buffer overruns. When a buffer overrun
> > occurs, tty_insert_flip_char returns 0, and no attempt is made to insert that
> > same character again (i.e. it is lost). This patch reports buffer overruns via
> > the buf_overrun field in the port's icount structure.
>
> I think this is mostly a misunderstanding - it's always been interpreted
> as logging hardware reported overrruns. The case of the software layer
> losing bytes is a "doesn't happen in normal circumstances" situation. At
> least it should be.
Hm, I applied this already, should I revert it?
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-15 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 17:35 [PATCH 1/1] serial_core: Update buffer overrun statistics Corbin Atkinson
2012-05-15 15:53 ` Alan Cox
2012-05-15 15:58 ` Greg Kroah-Hartman [this message]
2012-05-15 16:20 ` Corbin
2012-05-15 16:27 ` Alan Cox
2012-05-15 18:41 ` Corbin
2012-05-15 19:34 ` Jason Smith
2012-05-15 21:08 ` Alan Cox
2012-05-15 22:46 ` Corbin
2012-05-21 15:12 ` Jason Smith
2012-05-21 16:05 ` Alan Cox
2012-05-22 20:31 ` Corbin
2012-05-22 20:38 ` Jiri Slaby
2012-05-23 14:37 ` Corbin
2012-06-06 22:34 ` Corbin
2012-06-06 22:50 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515155833.GA24878@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbin.atkinson@ni.com \
--cc=corbinat@gmail.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.