All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Corbin <corbinat@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org,
	Corbin Atkinson <corbin.atkinson@ni.com>
Subject: Re: [PATCH 1/1] serial_core: Update buffer overrun statistics.
Date: Tue, 15 May 2012 22:08:31 +0100	[thread overview]
Message-ID: <20120515220831.11f04213@bob.linux.org.uk> (raw)
In-Reply-To: <CAA0x6_9dTE6zFaJOAqsrj2OcehARKG9KgicQPdf1yv2RjDbZwA@mail.gmail.com>

> it appears that the software buffer is actually artificially limited
> to 65536 bytes in the tty_buffer_alloc function in tty_buffer.c. I

Yes although you shouldn't be able to hit this with flow control
enabled. Without flow control we didn't overrun at that level.

it's really a semantics question - do we count stuff dumped
intentionally without flow control as an overrun.

I'm not fundamentally opposed to the idea but it is a change of meaning.

Other views ?

Alan

  parent reply	other threads:[~2012-05-15 20:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 17:35 [PATCH 1/1] serial_core: Update buffer overrun statistics Corbin Atkinson
2012-05-15 15:53 ` Alan Cox
2012-05-15 15:58   ` Greg Kroah-Hartman
2012-05-15 16:20     ` Corbin
2012-05-15 16:27       ` Alan Cox
2012-05-15 18:41         ` Corbin
2012-05-15 19:34           ` Jason Smith
2012-05-15 21:08           ` Alan Cox [this message]
2012-05-15 22:46             ` Corbin
2012-05-21 15:12               ` Jason Smith
2012-05-21 16:05                 ` Alan Cox
2012-05-22 20:31                   ` Corbin
2012-05-22 20:38                     ` Jiri Slaby
2012-05-23 14:37                       ` Corbin
2012-06-06 22:34                         ` Corbin
2012-06-06 22:50                           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120515220831.11f04213@bob.linux.org.uk \
    --to=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=corbin.atkinson@ni.com \
    --cc=corbinat@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.