Re: [PATCH] ASoC: dmic codec: Support for DT

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1719 bytes --]

On Tue, May 15, 2012 at 02:44:35PM +0300, Peter Ujfalusi wrote:

> I don't think that we would need platform devices for most of the
> passive components you have listed.

I don't think we do either, but I think we should handle DMICs in a
similar way - we probably want to be able to get to a place where basic
devices that don't need complex clocking arrangements can be described
with the device tree in a generic, cross-device manner.  I think that's
going to mean that we need to be able to enumerate things like which
pins on the CODEC are actually in use and where the headset is which is
going to need at least some level of description of these passives.

For internal Linux purposes we might want to do something noticeably
different with the different devices but that is an orthogonal issue to
representing the hardware in a suitably abstract format.  I would be a
bit worried if a DMIC interface was substantially different to an AMIC
interface in DT since in terms of how they interface it's really not
that big a difference.

> AFAIK (Liam can correct me if I'm wrong) the reason that we have this
> (dmic codec) is to be able to use the OMAP4+ DMIC in a card.

Oh, I understand why it's there but this is more of a Linux internal
implementation issue than anything else.

> Not entirely sure if we will need to have dts section for the dmic, I
> can just create the platform device in the abe-twl6040 machine driver if
> the setup includes digital microphones.

That's another option and certainly seems like a good stopgap when we're
currently doing the same thing for analogue interfaces - I'm much more
comfortable with adding stuff later than with putting something that
I've got concerns about in.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]