All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH] ASoC: dmic codec: Support for DT
Date: Tue, 15 May 2012 14:44:35 +0300	[thread overview]
Message-ID: <4FB241A3.3020104@ti.com> (raw)
In-Reply-To: <20120508125837.GN15893@opensource.wolfsonmicro.com>

On 05/08/2012 03:58 PM, Mark Brown wrote:
> On Tue, May 08, 2012 at 02:55:57PM +0300, Peter Ujfalusi wrote:
> 
>> +dmic_codec: dmic_codec@0 { /* generic DMIC codec */
>> +	compatible = "generic,dmic-codec";
>> +};
> 
> Why is this called "dmic-codec" and not "dmic"?  We probably need to
> have a think about this in the context of the handling of random
> on-board passive components in general - things like jacks and so on - 
> is the most sensible thing to have a platform device for everything, or
> is that getting too noisy?

I don't think that we would need platform devices for most of the
passive components you have listed.
AFAIK (Liam can correct me if I'm wrong) the reason that we have this
(dmic codec) is to be able to use the OMAP4+ DMIC in a card.
In most cases the digital microphones are passive components connected
to a codec and the codec is then interfaced with the CPU dai.
With the OMAP4 DMIC we have the microphones connected directly to the
CPU dai. In some sense the OMAP4+ DMIC block is a CPU dai and a codec at
the same time. Or we can view it as we have PDM link betweent he CPU dai
and the codec (dmic).

Not entirely sure if we will need to have dts section for the dmic, I
can just create the platform device in the abe-twl6040 machine driver if
the setup includes digital microphones.

-- 
Péter

  parent reply	other threads:[~2012-05-15 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 11:55 [PATCH] ASoC: dmic codec: Support for DT Peter Ujfalusi
2012-05-08 12:58 ` Mark Brown
2012-05-09 11:28   ` Peter Ujfalusi
2012-05-15 11:44   ` Peter Ujfalusi [this message]
2012-05-15 21:39     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB241A3.3020104@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.