From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sasha Levin <levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 2/2] cgroup: make css->refcnt clearing on cgroup removal optional
Date: Fri, 18 May 2012 10:55:48 -0700 [thread overview]
Message-ID: <20120518175548.GM19388@google.com> (raw)
In-Reply-To: <CA+1xoqe5hMuxzCRhMy7J0XchDk2ZnuxOHJKikROk1-ReAzcT6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, May 17, 2012 at 12:33:05AM +0200, Sasha Levin wrote:
> Hi Tejun,
>
> On Sun, Apr 1, 2012 at 8:54 PM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > Hello, Li.
> >
> > On Sun, Apr 01, 2012 at 10:00:26AM +0800, Li Zefan wrote:
> >> > Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> >>
> >> Both patches look good.
> >>
> >> Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> >
> > Alright, adding the patches to cgroup/for-3.5.
>
> This patch allows for race when removing a cgroup since one of the
> css's may still have a dentry ref when the cgroup is removed, no? Is
> there a plan to deal with that before this patch gets pushed into 3.5?
Can you please elaborate?
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Li Zefan <lizefan@huawei.com>,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, fweisbec@gmail.com, rni@google.com,
ctalbott@google.com, Vivek Goyal <vgoyal@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/2] cgroup: make css->refcnt clearing on cgroup removal optional
Date: Fri, 18 May 2012 10:55:48 -0700 [thread overview]
Message-ID: <20120518175548.GM19388@google.com> (raw)
In-Reply-To: <CA+1xoqe5hMuxzCRhMy7J0XchDk2ZnuxOHJKikROk1-ReAzcT6g@mail.gmail.com>
On Thu, May 17, 2012 at 12:33:05AM +0200, Sasha Levin wrote:
> Hi Tejun,
>
> On Sun, Apr 1, 2012 at 8:54 PM, Tejun Heo <tj@kernel.org> wrote:
> > Hello, Li.
> >
> > On Sun, Apr 01, 2012 at 10:00:26AM +0800, Li Zefan wrote:
> >> > Signed-off-by: Tejun Heo <tj@kernel.org>
> >>
> >> Both patches look good.
> >>
> >> Acked-by: Li Zefan <lizefan@huawei.com>
> >
> > Alright, adding the patches to cgroup/for-3.5.
>
> This patch allows for race when removing a cgroup since one of the
> css's may still have a dentry ref when the cgroup is removed, no? Is
> there a plan to deal with that before this patch gets pushed into 3.5?
Can you please elaborate?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-18 17:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 22:34 [PATCH 1/2] cgroup: use negative bias on css->refcnt to block css_tryget() Tejun Heo
2012-03-30 22:34 ` Tejun Heo
[not found] ` <20120330223423.GJ28934-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-30 22:36 ` [PATCH 2/2] cgroup: make css->refcnt clearing on cgroup removal optional Tejun Heo
2012-03-30 22:36 ` Tejun Heo
[not found] ` <20120330223606.GK28934-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-03-31 21:28 ` Hiroyuki Kamezawa
2012-03-31 21:28 ` Hiroyuki Kamezawa
2012-03-31 21:28 ` Hiroyuki Kamezawa
2012-04-01 2:00 ` Li Zefan
2012-04-01 2:00 ` Li Zefan
[not found] ` <4F77B6BA.4070207-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-04-01 18:54 ` Tejun Heo
2012-04-01 18:54 ` Tejun Heo
[not found] ` <20120401185430.GA9230-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-05-16 22:33 ` Sasha Levin
2012-05-16 22:33 ` Sasha Levin
[not found] ` <CA+1xoqe5hMuxzCRhMy7J0XchDk2ZnuxOHJKikROk1-ReAzcT6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-18 17:55 ` Tejun Heo [this message]
2012-05-18 17:55 ` Tejun Heo
[not found] ` <20120518175548.GM19388-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-18 18:28 ` Sasha Levin
2012-05-18 18:28 ` Sasha Levin
2012-05-18 18:28 ` Sasha Levin
[not found] ` <CA+1xoqfr5aaGbxoX3YKrJHXTjU9fWSbX_xbuEOU=4K7kMay6XQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-23 22:22 ` Tejun Heo
2012-05-23 22:22 ` Tejun Heo
2012-05-23 22:22 ` Tejun Heo
[not found] ` <20120523222242.GD3933-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-05-24 13:21 ` Sasha Levin
2012-05-24 13:21 ` Sasha Levin
[not found] ` <CA+1xoqdbtkC5Ue3s1qZHHJBLcj9a=djFDGny6AJJSV-pdn7mcA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-24 15:41 ` [PATCH] cgroup: superblock can't be released with active dentries Tejun Heo
2012-05-24 15:41 ` Tejun Heo
2012-05-24 15:41 ` Tejun Heo
[not found] ` <20120524154139.GA27983-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-28 0:18 ` Li Zefan
2012-05-28 0:18 ` Li Zefan
2012-05-24 13:21 ` [PATCH 2/2] cgroup: make css->refcnt clearing on cgroup removal optional Sasha Levin
2012-04-01 18:54 ` Tejun Heo
2012-04-01 2:00 ` Li Zefan
2012-04-01 19:48 ` Vivek Goyal
2012-04-01 19:48 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518175548.GM19388@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.