* [PATCH 1/1]USB:storage:fixed space at the start of a line issues.
@ 2012-05-18 19:18 Jeffrin Jose
2012-05-18 19:24 ` Greg KH
2012-05-19 13:48 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Jeffrin Jose @ 2012-05-18 19:18 UTC (permalink / raw)
To: mdharm-usb, gregkh; +Cc: linux-usb, usb-storage, linux-kernel, ahiliation
Fixed space at the start of a line issues found
by checkpatch.pl tool in drivers/usb/storage/usual-tables.c
Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
---
drivers/usb/storage/usual-tables.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
index b969279..f2301ee 100644
--- a/drivers/usb/storage/usual-tables.c
+++ b/drivers/usb/storage/usual-tables.c
@@ -34,17 +34,17 @@
vendorName, productName, useProtocol, useTransport, \
initFunction, flags) \
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
- .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
+.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
#define COMPLIANT_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax, \
vendorName, productName, useProtocol, useTransport, \
initFunction, flags) \
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
- .driver_info = (flags) }
+.driver_info = (flags) }
#define USUAL_DEV(useProto, useTrans, useType) \
{ USB_INTERFACE_INFO(USB_CLASS_MASS_STORAGE, useProto, useTrans), \
- .driver_info = ((useType)<<24) }
+.driver_info = ((useType)<<24) }
struct usb_device_id usb_storage_usb_ids[] = {
# include "unusual_devs.h"
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1]USB:storage:fixed space at the start of a line issues.
2012-05-18 19:18 [PATCH 1/1]USB:storage:fixed space at the start of a line issues Jeffrin Jose
@ 2012-05-18 19:24 ` Greg KH
2012-05-19 13:48 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2012-05-18 19:24 UTC (permalink / raw)
To: Jeffrin Jose; +Cc: mdharm-usb, linux-usb, usb-storage, linux-kernel
On Sat, May 19, 2012 at 12:48:35AM +0530, Jeffrin Jose wrote:
> Fixed space at the start of a line issues found
> by checkpatch.pl tool in drivers/usb/storage/usual-tables.c
>
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
Your subject is better, but now you forgot the spaces after the ':'
characters, what happened to them?
> ---
> drivers/usb/storage/usual-tables.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index b969279..f2301ee 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -34,17 +34,17 @@
> vendorName, productName, useProtocol, useTransport, \
> initFunction, flags) \
> { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> - .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
> +.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
That's dumb, and should not be changed, sorry.
checkpatch isn't always correct, please think when using it.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1]USB:storage:fixed space at the start of a line issues.
2012-05-18 19:18 [PATCH 1/1]USB:storage:fixed space at the start of a line issues Jeffrin Jose
2012-05-18 19:24 ` Greg KH
@ 2012-05-19 13:48 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2012-05-19 13:48 UTC (permalink / raw)
To: Jeffrin Jose; +Cc: mdharm-usb, gregkh, linux-usb, usb-storage, linux-kernel
Hello.
On 18-05-2012 23:18, Jeffrin Jose wrote:
> Fixed space at the start of a line issues found
> by checkpatch.pl tool in drivers/usb/storage/usual-tables.c
> Signed-off-by: Jeffrin Jose<ahiliation@yahoo.co.in>
> ---
> drivers/usb/storage/usual-tables.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
> index b969279..f2301ee 100644
> --- a/drivers/usb/storage/usual-tables.c
> +++ b/drivers/usb/storage/usual-tables.c
> @@ -34,17 +34,17 @@
> vendorName, productName, useProtocol, useTransport, \
> initFunction, flags) \
> { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> - .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
> +.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
Spaces are usually replaced by tab. Without indentation this looks worse
than it was.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-19 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-18 19:18 [PATCH 1/1]USB:storage:fixed space at the start of a line issues Jeffrin Jose
2012-05-18 19:24 ` Greg KH
2012-05-19 13:48 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.