From: Grant Likely <grant.likely@secretlab.ca>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] irqdomain: Export remaining public API symbols.
Date: Sat, 19 May 2012 18:34:46 +0000 [thread overview]
Message-ID: <20120519183446.C55013E03B8@localhost> (raw)
In-Reply-To: <1337407908-7421-3-git-send-email-lethal@linux-sh.org>
On Sat, 19 May 2012 15:11:42 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> modules making use of irq domains at the very least need access to the
> add/remove/lookup routines, though there's nothing preventing them from
> using the remainder of the public API, either.
>
> The current set of exports seem primarily geared at DT-enabled platforms
> using DT-backed IRQ domains, where many of the API accesses are hidden
> away in OF code. The non-DT cases need to do most of this on their own.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 9cae0b2..01d4a0d 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -122,6 +122,7 @@ void irq_domain_remove(struct irq_domain *domain)
>
> irq_domain_free(domain);
> }
> +EXPORT_SYMBOL_GPL(irq_domain_remove);
>
> static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain,
> irq_hw_number_t hwirq)
> @@ -209,6 +210,7 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
> irq_domain_add(domain);
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_legacy);
>
> /**
> * irq_domain_add_linear() - Allocate and register a legacy revmap irq_domain.
> @@ -238,6 +240,7 @@ struct irq_domain *irq_domain_add_linear(struct device_node *of_node,
> irq_domain_add(domain);
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_linear);
>
> struct irq_domain *irq_domain_add_nomap(struct device_node *of_node,
> unsigned int max_irq,
> @@ -252,6 +255,7 @@ struct irq_domain *irq_domain_add_nomap(struct device_node *of_node,
> }
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_nomap);
>
> /**
> * irq_domain_add_tree()
> @@ -273,6 +277,7 @@ struct irq_domain *irq_domain_add_tree(struct device_node *of_node,
> }
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_tree);
>
> /**
> * irq_find_host() - Locates a domain for a given device node
> @@ -320,6 +325,7 @@ void irq_set_default_host(struct irq_domain *domain)
>
> irq_default_domain = domain;
> }
> +EXPORT_SYMBOL_GPL(irq_set_default_host);
>
> static int irq_setup_virq(struct irq_domain *domain, unsigned int virq,
> irq_hw_number_t hwirq)
> @@ -378,6 +384,7 @@ unsigned int irq_create_direct_mapping(struct irq_domain *domain)
>
> return virq;
> }
> +EXPORT_SYMBOL_GPL(irq_create_direct_mapping);
>
> /**
> * irq_create_mapping() - Map a hardware interrupt into linux irq space
> @@ -617,6 +624,7 @@ unsigned int irq_radix_revmap_lookup(struct irq_domain *domain,
> */
> return irq_data ? irq_data->irq : irq_find_mapping(domain, hwirq);
> }
> +EXPORT_SYMBOL_GPL(irq_radix_revmap_lookup);
>
> /**
> * irq_radix_revmap_insert() - Insert a hw irq to linux irq number mapping.
> @@ -641,6 +649,7 @@ void irq_radix_revmap_insert(struct irq_domain *domain, unsigned int virq,
> mutex_unlock(&revmap_trees_mutex);
> }
> }
> +EXPORT_SYMBOL_GPL(irq_radix_revmap_insert);
>
> /**
> * irq_linear_revmap() - Find a linux irq from a hw irq number.
> @@ -674,6 +683,7 @@ unsigned int irq_linear_revmap(struct irq_domain *domain,
>
> return revmap[hwirq];
> }
> +EXPORT_SYMBOL_GPL(irq_linear_revmap);
>
> #ifdef CONFIG_IRQ_DOMAIN_DEBUG
> static int virq_debug_show(struct seq_file *m, void *private)
> --
> 1.7.9.rc0.28.g0e1cf
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 2/8] irqdomain: Export remaining public API symbols.
Date: Sat, 19 May 2012 12:34:46 -0600 [thread overview]
Message-ID: <20120519183446.C55013E03B8@localhost> (raw)
In-Reply-To: <1337407908-7421-3-git-send-email-lethal@linux-sh.org>
On Sat, 19 May 2012 15:11:42 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> modules making use of irq domains at the very least need access to the
> add/remove/lookup routines, though there's nothing preventing them from
> using the remainder of the public API, either.
>
> The current set of exports seem primarily geared at DT-enabled platforms
> using DT-backed IRQ domains, where many of the API accesses are hidden
> away in OF code. The non-DT cases need to do most of this on their own.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 9cae0b2..01d4a0d 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -122,6 +122,7 @@ void irq_domain_remove(struct irq_domain *domain)
>
> irq_domain_free(domain);
> }
> +EXPORT_SYMBOL_GPL(irq_domain_remove);
>
> static unsigned int irq_domain_legacy_revmap(struct irq_domain *domain,
> irq_hw_number_t hwirq)
> @@ -209,6 +210,7 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node,
> irq_domain_add(domain);
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_legacy);
>
> /**
> * irq_domain_add_linear() - Allocate and register a legacy revmap irq_domain.
> @@ -238,6 +240,7 @@ struct irq_domain *irq_domain_add_linear(struct device_node *of_node,
> irq_domain_add(domain);
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_linear);
>
> struct irq_domain *irq_domain_add_nomap(struct device_node *of_node,
> unsigned int max_irq,
> @@ -252,6 +255,7 @@ struct irq_domain *irq_domain_add_nomap(struct device_node *of_node,
> }
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_nomap);
>
> /**
> * irq_domain_add_tree()
> @@ -273,6 +277,7 @@ struct irq_domain *irq_domain_add_tree(struct device_node *of_node,
> }
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_add_tree);
>
> /**
> * irq_find_host() - Locates a domain for a given device node
> @@ -320,6 +325,7 @@ void irq_set_default_host(struct irq_domain *domain)
>
> irq_default_domain = domain;
> }
> +EXPORT_SYMBOL_GPL(irq_set_default_host);
>
> static int irq_setup_virq(struct irq_domain *domain, unsigned int virq,
> irq_hw_number_t hwirq)
> @@ -378,6 +384,7 @@ unsigned int irq_create_direct_mapping(struct irq_domain *domain)
>
> return virq;
> }
> +EXPORT_SYMBOL_GPL(irq_create_direct_mapping);
>
> /**
> * irq_create_mapping() - Map a hardware interrupt into linux irq space
> @@ -617,6 +624,7 @@ unsigned int irq_radix_revmap_lookup(struct irq_domain *domain,
> */
> return irq_data ? irq_data->irq : irq_find_mapping(domain, hwirq);
> }
> +EXPORT_SYMBOL_GPL(irq_radix_revmap_lookup);
>
> /**
> * irq_radix_revmap_insert() - Insert a hw irq to linux irq number mapping.
> @@ -641,6 +649,7 @@ void irq_radix_revmap_insert(struct irq_domain *domain, unsigned int virq,
> mutex_unlock(&revmap_trees_mutex);
> }
> }
> +EXPORT_SYMBOL_GPL(irq_radix_revmap_insert);
>
> /**
> * irq_linear_revmap() - Find a linux irq from a hw irq number.
> @@ -674,6 +683,7 @@ unsigned int irq_linear_revmap(struct irq_domain *domain,
>
> return revmap[hwirq];
> }
> +EXPORT_SYMBOL_GPL(irq_linear_revmap);
>
> #ifdef CONFIG_IRQ_DOMAIN_DEBUG
> static int virq_debug_show(struct seq_file *m, void *private)
> --
> 1.7.9.rc0.28.g0e1cf
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-05-19 18:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-19 6:11 [PATCH 0/8] irqdomain cleanups + identity mapping support Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 6:11 ` [PATCH 1/8] irqdomain: Support removal of IRQ domains Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:34 ` Grant Likely
2012-05-19 18:34 ` Grant Likely
2012-05-19 6:11 ` [PATCH 2/8] irqdomain: Export remaining public API symbols Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:34 ` Grant Likely [this message]
2012-05-19 18:34 ` Grant Likely
2012-05-19 6:11 ` [PATCH 3/8] irqdomain: Make irq_domain_simple_map() static Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:35 ` Grant Likely
2012-05-19 18:35 ` Grant Likely
2012-05-19 6:11 ` [PATCH 4/8] irqdomain: Simple NUMA awareness Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:41 ` Grant Likely
2012-05-19 18:41 ` Grant Likely
2012-05-21 4:46 ` Paul Mundt
2012-05-21 4:46 ` Paul Mundt
2012-05-19 6:11 ` [PATCH 5/8] irqdomain: Kill off duplicate definitions Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:42 ` Grant Likely
2012-05-19 18:42 ` Grant Likely
2012-05-19 6:11 ` [PATCH 6/8] irqdomain: Support identity mapped VIRQ allocation Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 20:21 ` Grant Likely
2012-05-19 20:21 ` Grant Likely
2012-05-21 4:55 ` Paul Mundt
2012-05-21 4:55 ` Paul Mundt
2012-05-19 6:11 ` [PATCH 7/8] irqdomain: trivial pr_fmt conversion Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 6:34 ` Joe Perches
2012-05-19 6:34 ` Joe Perches
2012-05-19 6:57 ` Paul Mundt
2012-05-19 6:57 ` Paul Mundt
2012-05-19 18:49 ` Grant Likely
2012-05-19 18:49 ` Grant Likely
2012-05-19 6:11 ` [PATCH 8/8] irqdomain: Support insertion of existing IRQ allocations Paul Mundt
2012-05-19 6:11 ` Paul Mundt
2012-05-19 18:32 ` [PATCH 0/8] irqdomain cleanups + identity mapping support Grant Likely
2012-05-19 18:32 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519183446.C55013E03B8@localhost \
--to=grant.likely@secretlab.ca \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.