From: Grant Likely <grant.likely@secretlab.ca>
To: David Daney <ddaney.cavm@gmail.com>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
spi-devel-general@lists.sourceforge.net,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
Date: Sat, 19 May 2012 23:26:53 -0600 [thread overview]
Message-ID: <20120520052653.590673E03B8@localhost> (raw)
In-Reply-To: <4FB14B55.4070604@gmail.com>
On Mon, 14 May 2012 11:13:41 -0700, David Daney <ddaney.cavm@gmail.com> wrote:
> On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:
> > Hi David,
> > A few comments.
> >
> > On Sat, May 12, 2012 at 3:04 AM, David Daney<ddaney.cavm@gmail.com> wrote:
> [...]
>
> >> +
> >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */
> > This could be given a miss. As it is less meaningful once accepted.
>
>
> Well, this leads to the question, what is the purpose of the
> 'MODULE_VERSION()' macro? If I use that, I need to populate it with a
> value.
Don't use MODULE_VERSION. Just because it is there doesn't mean you
need to use it. :-) You'll notice that none of the other spi drivers
have it.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: David Daney <ddaney.cavm@gmail.com>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
spi-devel-general@lists.sourceforge.net,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
Date: Sat, 19 May 2012 23:26:53 -0600 [thread overview]
Message-ID: <20120520052653.590673E03B8@localhost> (raw)
Message-ID: <20120520052653.2fzXe4ConDND5qWEwvZ95119dINX8eg1JZOvnLqzI3I@z> (raw)
In-Reply-To: <4FB14B55.4070604@gmail.com>
On Mon, 14 May 2012 11:13:41 -0700, David Daney <ddaney.cavm@gmail.com> wrote:
> On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:
> > Hi David,
> > A few comments.
> >
> > On Sat, May 12, 2012 at 3:04 AM, David Daney<ddaney.cavm@gmail.com> wrote:
> [...]
>
> >> +
> >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */
> > This could be given a miss. As it is less meaningful once accepted.
>
>
> Well, this leads to the question, what is the purpose of the
> 'MODULE_VERSION()' macro? If I use that, I need to populate it with a
> value.
Don't use MODULE_VERSION. Just because it is there doesn't mean you
need to use it. :-) You'll notice that none of the other spi drivers
have it.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Shubhrajyoti Datta <omaplinuxkernel@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
spi-devel-general@lists.sourceforge.net,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
Date: Sat, 19 May 2012 23:26:53 -0600 [thread overview]
Message-ID: <20120520052653.590673E03B8@localhost> (raw)
In-Reply-To: <4FB14B55.4070604@gmail.com>
On Mon, 14 May 2012 11:13:41 -0700, David Daney <ddaney.cavm@gmail.com> wrote:
> On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote:
> > Hi David,
> > A few comments.
> >
> > On Sat, May 12, 2012 at 3:04 AM, David Daney<ddaney.cavm@gmail.com> wrote:
> [...]
>
> >> +
> >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */
> > This could be given a miss. As it is less meaningful once accepted.
>
>
> Well, this leads to the question, what is the purpose of the
> 'MODULE_VERSION()' macro? If I use that, I need to populate it with a
> value.
Don't use MODULE_VERSION. Just because it is there doesn't mean you
need to use it. :-) You'll notice that none of the other spi drivers
have it.
g.
next prev parent reply other threads:[~2012-05-20 5:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 21:34 [PATCH 0/2] MIPS/spi: New driver for SPI master controller for OCTEON SOCs David Daney
2012-05-11 21:34 ` [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware David Daney
2012-05-11 21:34 ` David Daney
2012-05-14 20:02 ` Linus Walleij
2012-05-20 5:23 ` Grant Likely
2012-05-20 5:23 ` Grant Likely
2012-08-21 18:23 ` John Crispin
2012-05-11 21:34 ` [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs David Daney
2012-05-11 21:34 ` David Daney
2012-05-14 5:46 ` Shubhrajyoti Datta
2012-05-14 18:13 ` David Daney
2012-05-20 5:26 ` Grant Likely [this message]
2012-05-20 5:26 ` Grant Likely
2012-05-20 5:26 ` Grant Likely
2012-05-14 20:07 ` Linus Walleij
2012-05-14 20:07 ` Linus Walleij
2012-05-20 5:46 ` Grant Likely
2012-08-21 19:30 ` David Daney
2012-08-21 19:30 ` David Daney
2012-08-21 18:23 ` John Crispin
2012-08-21 18:33 ` David Daney
2012-08-21 18:35 ` John Crispin
2012-08-21 18:40 ` David Daney
2012-08-21 18:40 ` John Crispin
2012-08-21 19:49 ` [2/2] " Guenter Roeck
2012-08-21 19:49 ` Guenter Roeck
2012-08-21 20:38 ` David Daney
2012-08-21 20:38 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520052653.590673E03B8@localhost \
--to=grant.likely@secretlab.ca \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=omaplinuxkernel@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.