From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: spi-devel-general@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, kgene.kim@samsung.com,
jaswinder.singh@linaro.org
Subject: Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function
Date: Sun, 20 May 2012 10:21:13 +0100 [thread overview]
Message-ID: <20120520092113.GA20652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1337333613-6216-5-git-send-email-thomas.abraham@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote:
> - s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1);
> + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);
...
> + pd.src_clk_nr = src_clk_nr;
> + pd.cfg_gpio = (cfg_gpio) ? cfg_gpio : s3c64xx_spi0_cfg_gpio;
> + s3c64xx_device_spi0.name = dev_name;
This looks *really* strange. Why do we need to pass in a name to set in
s3c64xx_device_spi0's name, why would we want to use a different name?
This dev_name also isn't equivalent to dev_name() which makes matters
more confusing than they need to be.
There was similar code for the I2C controllers which caused some really
hard to debug brittleness.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function
Date: Sun, 20 May 2012 10:21:13 +0100 [thread overview]
Message-ID: <20120520092113.GA20652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1337333613-6216-5-git-send-email-thomas.abraham@linaro.org>
On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote:
> - s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1);
> + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);
...
> + pd.src_clk_nr = src_clk_nr;
> + pd.cfg_gpio = (cfg_gpio) ? cfg_gpio : s3c64xx_spi0_cfg_gpio;
> + s3c64xx_device_spi0.name = dev_name;
This looks *really* strange. Why do we need to pass in a name to set in
s3c64xx_device_spi0's name, why would we want to use a different name?
This dev_name also isn't equivalent to dev_name() which makes matters
more confusing than they need to be.
There was similar code for the I2C controllers which caused some really
hard to debug brittleness.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120520/aead2f08/attachment.sig>
next prev parent reply other threads:[~2012-05-20 9:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 9:33 [PATCH v2 0/6] spi: s3c64xx: add support for device tree Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-20 5:03 ` Grant Likely
2012-05-20 5:03 ` Grant Likely
2012-05-18 9:33 ` [PATCH v2 2/6] spi: s3c64xx: move controller information into driver data Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-20 5:06 ` Grant Likely
2012-05-20 5:06 ` Grant Likely
2012-05-24 7:18 ` Kukjin Kim
2012-05-24 7:18 ` Kukjin Kim
2012-05-24 8:43 ` Thomas Abraham
2012-05-24 8:43 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 3/6] ARM: Samsung: Remove pdev pointer paremeter from spi gpio setup functions Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-20 9:21 ` Mark Brown [this message]
2012-05-20 9:21 ` Mark Brown
2012-05-30 7:28 ` Olof Johansson
2012-05-30 7:28 ` Olof Johansson
2012-05-30 7:47 ` Thomas Abraham
2012-05-30 7:47 ` Thomas Abraham
2012-05-30 9:34 ` Mark Brown
2012-05-30 9:34 ` Mark Brown
2012-05-30 10:05 ` Thomas Abraham
2012-05-30 10:05 ` Thomas Abraham
2012-05-30 10:13 ` Mark Brown
2012-05-30 10:13 ` Mark Brown
[not found] ` <20120530101326.GF9947-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-05-31 2:05 ` Thomas Abraham
2012-05-31 2:05 ` Thomas Abraham
2012-05-31 11:36 ` Mark Brown
2012-05-31 11:36 ` Mark Brown
[not found] ` <20120531113659.GB2666-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-06-01 2:47 ` Thomas Abraham
2012-06-01 2:47 ` Thomas Abraham
2012-06-01 12:39 ` Mark Brown
2012-06-01 12:39 ` Mark Brown
2012-06-03 9:29 ` Thomas Abraham
2012-06-03 9:29 ` Thomas Abraham
2012-05-18 9:33 ` [PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-20 5:07 ` Grant Likely
2012-05-20 5:07 ` Grant Likely
2012-05-18 9:33 ` [PATCH v2 6/6] spi: s3c64xx: add device tree support Thomas Abraham
2012-05-18 9:33 ` Thomas Abraham
2012-05-20 5:10 ` Grant Likely
2012-05-20 5:10 ` Grant Likely
2012-05-20 5:02 ` [PATCH v2 0/6] spi: s3c64xx: add support for device tree Grant Likely
2012-05-20 5:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120520092113.GA20652@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.