From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
U-Boot Mailing List
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Allen Martin <amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: Unifying device tree filenames, and U-Boot SoC name
Date: Mon, 21 May 2012 16:22:14 +0200 [thread overview]
Message-ID: <20120521142214.GC21513@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <4FB3E788.2040801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
* Stephen Warren wrote:
> I just posted a patch which causes U-Boot to define some variables
> describing which board you're running on:
>
> http://lists.denx.de/pipermail/u-boot/2012-May/124556.html
>
> In particular, see the description of that first patch for motivation
> re: U-Boot scripts.
>
> The one issue here is that the U-Boot SoC name for Tegra20 is tegra2
> (hence it will define board_soc=tegra2), whereas the kernel's device
> tree files are all tegra-*.dts not tegra2-*.dts.
>
> I propose we fix this by:
>
> a) In the kernel, renaming tegra*-${board}.dts to tegra20-${board}.dts
> (or tegra30-${board}.dts). This appears to better match what most other
> ARM sub-arches are doing anyway.
>
> b) In U-Boot, rename the tegra2 support to tegra20 so that U-Boot ends
> up setting board_soc=tegra20, so this matches the .dts/.dtb filenames.
> This would involve renaming arch/arm/cpu/armv7/tegra2/ to
> ./arch/arm/cpu/armv7/tegra20/ and editing boards.cfg to match, and
> possibly other related changes.
>
> This sounds like churn, but I think we could easily fold this into
> Allen's series that moves the tegra2 directory in order to put it in a
> common place for separate SPL/non-SPL builds to avoid doing this kind of
> thing multiple times.
>
> Does anyone think this is a good/bad/... idea? Thanks.
I like it. It's better to have the names consistent.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Unifying device tree filenames, and U-Boot SoC name
Date: Mon, 21 May 2012 16:22:14 +0200 [thread overview]
Message-ID: <20120521142214.GC21513@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <4FB3E788.2040801@wwwdotorg.org>
* Stephen Warren wrote:
> I just posted a patch which causes U-Boot to define some variables
> describing which board you're running on:
>
> http://lists.denx.de/pipermail/u-boot/2012-May/124556.html
>
> In particular, see the description of that first patch for motivation
> re: U-Boot scripts.
>
> The one issue here is that the U-Boot SoC name for Tegra20 is tegra2
> (hence it will define board_soc=tegra2), whereas the kernel's device
> tree files are all tegra-*.dts not tegra2-*.dts.
>
> I propose we fix this by:
>
> a) In the kernel, renaming tegra*-${board}.dts to tegra20-${board}.dts
> (or tegra30-${board}.dts). This appears to better match what most other
> ARM sub-arches are doing anyway.
>
> b) In U-Boot, rename the tegra2 support to tegra20 so that U-Boot ends
> up setting board_soc=tegra20, so this matches the .dts/.dtb filenames.
> This would involve renaming arch/arm/cpu/armv7/tegra2/ to
> ./arch/arm/cpu/armv7/tegra20/ and editing boards.cfg to match, and
> possibly other related changes.
>
> This sounds like churn, but I think we could easily fold this into
> Allen's series that moves the tegra2 directory in order to put it in a
> common place for separate SPL/non-SPL builds to avoid doing this kind of
> thing multiple times.
>
> Does anyone think this is a good/bad/... idea? Thanks.
I like it. It's better to have the names consistent.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120521/fc53ede3/attachment.pgp>
next prev parent reply other threads:[~2012-05-21 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 17:44 Unifying device tree filenames, and U-Boot SoC name Stephen Warren
2012-05-16 17:44 ` [U-Boot] " Stephen Warren
[not found] ` <4FB3E788.2040801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-05-21 14:22 ` Thierry Reding [this message]
2012-05-21 14:22 ` Thierry Reding
2012-05-22 0:49 ` Simon Glass
2012-05-22 0:49 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ3rcprV5Es3Omcnwr8EdvP+1E94U__Ou_9wzw1048beNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-22 1:01 ` Allen Martin
2012-05-22 1:01 ` [U-Boot] " Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521142214.GC21513@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.