All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andi Kleen <ak@linux.intel.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au,
	akpm@linux-foundation.org
Subject: Re: [PATCH] fs: Fix NULL pointer dereference at copy_mnt_ns().
Date: Mon, 21 May 2012 19:35:13 +0100	[thread overview]
Message-ID: <20120521183513.GD11775@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120521182721.GB21406@tassilo.jf.intel.com>

On Mon, May 21, 2012 at 11:27:21AM -0700, Andi Kleen wrote:
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index 5a6208b..224aff1 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -2250,6 +2250,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,
> >  		kfree(new_ns);
> >  		return ERR_PTR(-ENOMEM);
> >  	}
> > +	new_ns->root = new;
> 
> 
> oops. Thanks for finding that. Must have been a merge error somewhere.

Nah, just me cherry-picking unfixed variant.  It had come up back in March,
remember?  Replaced with fixed variant in the local tree, will go into
for-next (and for-linus, while we are at it) tonight or tomorrow morning.

      reply	other threads:[~2012-05-21 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 15:35 [PATCH] fs: Fix NULL pointer dereference at copy_mnt_ns() Tetsuo Handa
2012-05-21 18:27 ` Andi Kleen
2012-05-21 18:35   ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120521183513.GD11775@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.