From: Ted Ts'o <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: manish honap <manish_honap_vit@yahoo.co.in>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.
Date: Mon, 21 May 2012 19:31:33 -0400 [thread overview]
Message-ID: <20120521233133.GG12339@thunk.org> (raw)
In-Reply-To: <CA+55aFyGJTJh3jddXdapQiC4ou=sS9PFMcX_qVUGa5qBjUZjDg@mail.gmail.com>
On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote:
>
> So I'm pretty sure this patch is what we want, and rw_verify_area()
> really is required to protect low-level filesystems from these kinds
> of issues. Not just ext4.
>
> At the same time, I would *really* want somebody who actually uses
> anything AIO to test it out too. Because I want to not only commit it,
> but also mark it for stable - and it would be nice to have some more
> testing than me saying "ok, it passes the one test-case sent to me"
> and "hey, the code looks sane".
Hi Linus,
We do use AIO at Google, and I primarily use fio (usually as part of
xfstests) to test AIO functionality.
If you like I can carry the patch in the ext4 tree and test it as part
of the ext4 commits for the merge window.
I probably won't be able to get to it until a bit later in the week,
though. Things have been really crazy for me this past two months...
- Ted
next prev parent reply other threads:[~2012-05-21 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F9014F50-D1F6-4B64-8535-7452CC64B18A@qualexsystems.com>
2012-05-20 8:01 ` [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code manish honap
2012-05-20 18:33 ` Linus Torvalds
2012-05-21 3:28 ` manish honap
2012-05-21 4:50 ` Linus Torvalds
2012-05-21 22:22 ` Linus Torvalds
2012-05-21 23:31 ` Ted Ts'o [this message]
2012-05-22 16:11 ` Eric Sandeen
2012-05-22 19:02 ` Eric Sandeen
2012-05-22 16:13 ` manish honap
2012-05-22 19:26 ` [PATCH 1/1] xfstests 286: test for 2G overflows in AIO Eric Sandeen
2012-05-22 20:41 ` [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521233133.GG12339@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=manish_honap_vit@yahoo.co.in \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.