From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Ted Ts'o <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
manish honap <manish_honap_vit@yahoo.co.in>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.
Date: Tue, 22 May 2012 14:02:17 -0500 [thread overview]
Message-ID: <4FBBE2B9.6030304@sandeen.net> (raw)
In-Reply-To: <4FBBBA98.9090101@redhat.com>
On 5/22/12 11:11 AM, Eric Sandeen wrote:
> On 5/21/12 6:31 PM, Ted Ts'o wrote:
>> On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote:
>>>
>>> So I'm pretty sure this patch is what we want, and rw_verify_area()
>>> really is required to protect low-level filesystems from these kinds
>>> of issues. Not just ext4.
>>>
>>> At the same time, I would *really* want somebody who actually uses
>>> anything AIO to test it out too. Because I want to not only commit it,
>>> but also mark it for stable - and it would be nice to have some more
>>> testing than me saying "ok, it passes the one test-case sent to me"
>>> and "hey, the code looks sane".
>
> Just FWIW, the ext4_file_write() part of this fix was sent by Zheng Liu on 4/12/12:
>
> [PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write
Sorry, I was talking about Manish's original patch, not Linus's followup.
-Eric
> I'll see about writing an xfstest for this stuff too so it doesn't regress again.
>
> -Eric
>
next prev parent reply other threads:[~2012-05-22 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F9014F50-D1F6-4B64-8535-7452CC64B18A@qualexsystems.com>
2012-05-20 8:01 ` [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code manish honap
2012-05-20 18:33 ` Linus Torvalds
2012-05-21 3:28 ` manish honap
2012-05-21 4:50 ` Linus Torvalds
2012-05-21 22:22 ` Linus Torvalds
2012-05-21 23:31 ` Ted Ts'o
2012-05-22 16:11 ` Eric Sandeen
2012-05-22 19:02 ` Eric Sandeen [this message]
2012-05-22 16:13 ` manish honap
2012-05-22 19:26 ` [PATCH 1/1] xfstests 286: test for 2G overflows in AIO Eric Sandeen
2012-05-22 20:41 ` [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBE2B9.6030304@sandeen.net \
--to=sandeen@sandeen.net \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=manish_honap_vit@yahoo.co.in \
--cc=sandeen@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.