From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/12] ARM: imx6q: add config-on-boot gpios
Date: Tue, 22 May 2012 07:22:00 +0200 [thread overview]
Message-ID: <201205220722.00653.marex@denx.de> (raw)
In-Reply-To: <20120522044223.GJ8140@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Tue, May 22, 2012 at 06:20:16AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> >
> > > On 22 May 2012 11:25, Marek Vasut <marex@denx.de> wrote:
> > > > Dear Shawn Guo,
> > > >
> > > >> Apart from my comments below, we really need to know Rob and Grant's
> > > >> opinion on this.
> > > >
> > > > Hm ... so why don't you actually write per-board driver ? :-) That'd
> > > > handle every single board very well, you'd configure the GPIOs there,
> > > > every single additional necessary thing that has to be configured
> > > > would sink there too etc.
> > >
> > > I'm not completely sure about how the per-board driver looks like
> > > exactly. Can you have some code demonstrating it?
> >
> > Well such per-board driver would handle the board-specific init, like
> > configuring the hub GPIO (as Richard has to do so on mx6q) or flick some
> > other GPIOs, configure registers etc.
>
> So when you say driver, you just meant a C file like imx6q-sabrelite.c
> containing a number of init functions to be called by mach-imx6q.c?
Something like that ... but didn't Linus complain that we have too many files in
arch/arm/ ?
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Richard Zhao
<richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
B29397-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
B20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
dong.aisheng-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linuxzsc-MeMPY/F8WlbQT0dZR+AlfA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Subject: Re: [PATCH v2 07/12] ARM: imx6q: add config-on-boot gpios
Date: Tue, 22 May 2012 07:22:00 +0200 [thread overview]
Message-ID: <201205220722.00653.marex@denx.de> (raw)
In-Reply-To: <20120522044223.GJ8140-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
Dear Shawn Guo,
> On Tue, May 22, 2012 at 06:20:16AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> >
> > > On 22 May 2012 11:25, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
> > > > Dear Shawn Guo,
> > > >
> > > >> Apart from my comments below, we really need to know Rob and Grant's
> > > >> opinion on this.
> > > >
> > > > Hm ... so why don't you actually write per-board driver ? :-) That'd
> > > > handle every single board very well, you'd configure the GPIOs there,
> > > > every single additional necessary thing that has to be configured
> > > > would sink there too etc.
> > >
> > > I'm not completely sure about how the per-board driver looks like
> > > exactly. Can you have some code demonstrating it?
> >
> > Well such per-board driver would handle the board-specific init, like
> > configuring the hub GPIO (as Richard has to do so on mx6q) or flick some
> > other GPIOs, configure registers etc.
>
> So when you say driver, you just meant a C file like imx6q-sabrelite.c
> containing a number of init functions to be called by mach-imx6q.c?
Something like that ... but didn't Linus complain that we have too many files in
arch/arm/ ?
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-22 5:22 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 9:23 [PATCH v2 00/12] add imx usb driver for mx28/6x Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 01/12] usb: otg: add notify_connect_change callback Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-21 9:26 ` Felipe Balbi
2012-05-21 9:26 ` Felipe Balbi
2012-05-21 9:36 ` Richard Zhao
2012-05-21 9:36 ` Richard Zhao
2012-05-21 9:38 ` Felipe Balbi
2012-05-21 9:38 ` Felipe Balbi
2012-05-21 10:19 ` Richard Zhao
2012-05-21 10:19 ` Richard Zhao
2012-05-21 13:03 ` Greg KH
2012-05-21 13:03 ` Greg KH
2012-05-21 13:05 ` Greg KH
2012-05-21 13:05 ` Greg KH
2012-05-21 17:36 ` Marek Vasut
2012-05-21 17:36 ` Marek Vasut
2012-05-21 17:47 ` Greg KH
2012-05-21 17:47 ` Greg KH
2012-05-21 18:32 ` Marek Vasut
2012-05-21 18:32 ` Marek Vasut
2012-05-21 18:40 ` Greg KH
2012-05-21 18:40 ` Greg KH
2012-05-21 19:27 ` Marek Vasut
2012-05-21 19:27 ` Marek Vasut
2012-05-22 0:27 ` Richard Zhao
2012-05-22 0:27 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 02/12] usb: chipidea: permit driver bindings pass phy pointer Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:22 ` Marek Vasut
2012-05-22 4:22 ` Marek Vasut
2012-05-22 9:59 ` Alexander Shishkin
2012-05-22 9:59 ` Alexander Shishkin
2012-05-22 14:07 ` Marek Vasut
2012-05-22 14:07 ` Marek Vasut
2012-05-22 15:14 ` Richard Zhao
2012-05-22 15:14 ` Richard Zhao
2012-05-23 1:35 ` Chen Peter-B29397
2012-05-23 1:35 ` Chen Peter-B29397
2012-05-23 8:08 ` Alexander Shishkin
2012-05-23 8:08 ` Alexander Shishkin
2012-05-21 9:23 ` [PATCH v2 03/12] usb: ehci-hcd: notify phy when connect change Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:23 ` Marek Vasut
2012-05-22 4:23 ` Marek Vasut
2012-05-22 4:36 ` Richard Zhao
2012-05-22 4:36 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 04/12] usb: otg: add basic mxs phy driver support Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 05/12] usb: chipidea: add imx driver binding Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:30 ` Marek Vasut
2012-05-22 4:30 ` Marek Vasut
2012-05-22 4:51 ` Richard Zhao
2012-05-22 4:51 ` Richard Zhao
2012-05-22 9:56 ` Alexander Shishkin
2012-05-22 9:56 ` Alexander Shishkin
2012-05-22 10:06 ` Felipe Balbi
2012-05-22 10:06 ` Felipe Balbi
2012-05-22 10:31 ` Richard Zhao
2012-05-22 10:31 ` Richard Zhao
2012-05-22 10:35 ` Felipe Balbi
2012-05-22 10:35 ` Felipe Balbi
2012-05-22 10:41 ` Alexander Shishkin
2012-05-22 10:41 ` Alexander Shishkin
2012-05-22 15:06 ` Richard Zhao
2012-05-22 15:06 ` Richard Zhao
2012-05-23 13:02 ` Alexander Shishkin
2012-05-23 13:02 ` Alexander Shishkin
2012-05-23 13:09 ` Felipe Balbi
2012-05-23 13:09 ` Felipe Balbi
2012-05-23 13:13 ` Alexander Shishkin
2012-05-23 13:13 ` Alexander Shishkin
2012-05-22 13:52 ` Shawn Guo
2012-05-22 13:52 ` Shawn Guo
2012-05-22 13:55 ` Felipe Balbi
2012-05-22 13:55 ` Felipe Balbi
2012-05-22 10:21 ` Alexander Shishkin
2012-05-22 10:21 ` Alexander Shishkin
2012-05-22 10:24 ` Alexander Shishkin
2012-05-22 10:24 ` Alexander Shishkin
2012-05-22 15:30 ` Richard Zhao
2012-05-22 15:30 ` Richard Zhao
2012-05-22 15:28 ` Richard Zhao
2012-05-22 15:28 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 06/12] ARM: imx6q: correct device name of usbphy and usb controller clock export Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:31 ` Marek Vasut
2012-05-22 4:31 ` Marek Vasut
2012-05-22 4:56 ` Richard Zhao
2012-05-22 4:56 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 07/12] ARM: imx6q: add config-on-boot gpios Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 3:17 ` Shawn Guo
2012-05-22 3:17 ` Shawn Guo
2012-05-22 3:25 ` Marek Vasut
2012-05-22 3:25 ` Marek Vasut
2012-05-22 3:32 ` Shawn Guo
2012-05-22 3:32 ` Shawn Guo
2012-05-22 4:20 ` Marek Vasut
2012-05-22 4:20 ` Marek Vasut
2012-05-22 4:42 ` Shawn Guo
2012-05-22 4:42 ` Shawn Guo
2012-05-22 5:22 ` Marek Vasut [this message]
2012-05-22 5:22 ` Marek Vasut
2012-05-22 5:25 ` Shawn Guo
2012-05-22 5:25 ` Shawn Guo
2012-05-22 5:27 ` Marek Vasut
2012-05-22 5:27 ` Marek Vasut
2012-05-22 6:07 ` Richard Zhao
2012-05-22 6:07 ` Richard Zhao
2012-05-22 3:38 ` Richard Zhao
2012-05-22 3:38 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 08/12] ARM: imx6q: add usbphy clocks Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:32 ` Marek Vasut
2012-05-22 4:32 ` Marek Vasut
2012-05-22 4:45 ` Shawn Guo
2012-05-22 4:45 ` Shawn Guo
2012-05-22 5:22 ` Marek Vasut
2012-05-22 5:22 ` Marek Vasut
2012-05-22 4:59 ` Richard Zhao
2012-05-22 4:59 ` Richard Zhao
2012-05-22 5:37 ` Shawn Guo
2012-05-22 5:37 ` Shawn Guo
2012-05-22 6:08 ` Richard Zhao
2012-05-22 6:08 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 09/12] ARM: imx6q: disable usb charger detector Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 3:48 ` Shawn Guo
2012-05-22 3:48 ` Shawn Guo
2012-05-22 4:32 ` Richard Zhao
2012-05-22 4:32 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 10/12] ARM: dts: imx6q-sabrelite: add usb devices Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 5:10 ` Shawn Guo
2012-05-22 5:10 ` Shawn Guo
2012-05-22 5:59 ` Richard Zhao
2012-05-22 5:59 ` Richard Zhao
2012-05-22 6:08 ` Shawn Guo
2012-05-22 6:08 ` Shawn Guo
2012-05-22 6:19 ` Richard Zhao
2012-05-22 6:19 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 11/12] ARM: mxs: clk_register_clkdev mx28 usb clocks Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:48 ` Shawn Guo
2012-05-22 4:48 ` Shawn Guo
2012-05-22 5:01 ` Richard Zhao
2012-05-22 5:01 ` Richard Zhao
2012-05-21 9:23 ` [PATCH v2 12/12] ARM: dts: imx28-evk: add usb devices Richard Zhao
2012-05-21 9:23 ` Richard Zhao
2012-05-22 4:52 ` Shawn Guo
2012-05-22 4:52 ` Shawn Guo
2012-05-22 5:03 ` Richard Zhao
2012-05-22 5:03 ` Richard Zhao
2012-05-22 5:24 ` Marek Vasut
2012-05-22 5:24 ` Marek Vasut
2012-05-21 19:34 ` [PATCH v2 00/12] add imx usb driver for mx28/6x Fabio Estevam
2012-05-21 19:34 ` Fabio Estevam
2012-05-21 19:41 ` Marek Vasut
2012-05-21 19:41 ` Marek Vasut
2012-05-21 19:47 ` Subodh Nijsure
2012-05-21 19:47 ` Subodh Nijsure
2012-05-21 20:07 ` Marek Vasut
2012-05-21 20:07 ` Marek Vasut
2012-05-22 1:38 ` Chen Peter-B29397
2012-05-22 1:38 ` Chen Peter-B29397
2012-05-22 1:41 ` Richard Zhao
2012-05-22 1:41 ` Richard Zhao
2012-05-22 1:44 ` Chen Peter-B29397
2012-05-22 1:44 ` Chen Peter-B29397
2012-05-22 1:51 ` Richard Zhao
2012-05-22 1:51 ` Richard Zhao
2012-05-22 2:00 ` Shawn Guo
2012-05-22 2:00 ` Shawn Guo
2012-05-22 5:08 ` Richard Zhao
2012-05-22 5:08 ` Richard Zhao
2012-05-22 13:13 ` Dirk Behme
2012-05-22 13:13 ` Dirk Behme
2012-05-24 3:38 ` Richard Zhao
2012-05-24 3:38 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205220722.00653.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.