From: David Brown <davidb@codeaurora.org>
To: Rajendra Nayak <rnayak@ti.com>
Cc: broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca,
robherring2@gmail.com, linaro-dev@lists.linaro.org,
patches@linaro.org, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
lrg@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data
Date: Wed, 23 May 2012 10:48:03 -0700 [thread overview]
Message-ID: <20120523174803.GA18609@codeaurora.org> (raw)
In-Reply-To: <1321615040-13257-2-git-send-email-rnayak@ti.com>
On Fri, Nov 18, 2011 at 04:47:17PM +0530, Rajendra Nayak wrote:
> + xyzreg: regulator@0 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + vin-supply = <&vin>;
> + };
Just noticed this, but the '@0' shouldn't be on the name, since there
isn't a reg attribute on this node. Perhaps it should be
"regulator-xyz"?
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data
Date: Wed, 23 May 2012 10:48:03 -0700 [thread overview]
Message-ID: <20120523174803.GA18609@codeaurora.org> (raw)
In-Reply-To: <1321615040-13257-2-git-send-email-rnayak@ti.com>
On Fri, Nov 18, 2011 at 04:47:17PM +0530, Rajendra Nayak wrote:
> + xyzreg: regulator at 0 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + vin-supply = <&vin>;
> + };
Just noticed this, but the '@0' shouldn't be on the name, since there
isn't a reg attribute on this node. Perhaps it should be
"regulator-xyz"?
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-05-23 17:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 11:17 [PATCH v5 0/4] Device tree support for regulators Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
[not found] ` <1321615040-13257-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-11-18 11:17 ` [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-12-04 13:21 ` Thomas Abraham
2011-12-04 13:21 ` Thomas Abraham
2011-12-04 13:21 ` Thomas Abraham
2011-12-04 15:54 ` Mark Brown
2011-12-04 15:54 ` Mark Brown
2011-12-05 9:10 ` Thomas Abraham
2011-12-05 9:10 ` Thomas Abraham
2011-12-05 9:10 ` Thomas Abraham
2011-12-05 10:34 ` Mark Brown
2011-12-05 10:34 ` Mark Brown
2011-12-05 10:44 ` Thomas Abraham
2011-12-05 10:44 ` Thomas Abraham
[not found] ` <CAJuYYwSRW-=XufvHS1miO2xNANwQMZqPbt=VyPEonywnAsvVUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 10:57 ` Mark Brown
2011-12-05 10:57 ` Mark Brown
2011-12-05 10:57 ` Mark Brown
[not found] ` <20111205105733.GE11150-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-12-05 11:09 ` Thomas Abraham
2011-12-05 11:09 ` Thomas Abraham
2011-12-05 11:09 ` Thomas Abraham
2011-12-06 6:54 ` Rajendra Nayak
2011-12-06 6:54 ` Rajendra Nayak
2011-12-06 6:54 ` Rajendra Nayak
2012-05-23 17:48 ` David Brown [this message]
2012-05-23 17:48 ` David Brown
2011-11-18 11:17 ` [PATCH v5 2/4] regulator: adapt fixed regulator driver to dt Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 3/4] regulator: pass additional of_node to regulator_register() Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-12-04 9:53 ` Thomas Abraham
2011-12-04 9:53 ` Thomas Abraham
2011-12-04 9:53 ` Thomas Abraham
[not found] ` <CAJuYYwRa=AGZ+Chuj+v49EHE+bOuoCWxhmDUO35BoZK2g97FQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 7:19 ` Rajendra Nayak
2011-12-05 7:19 ` Rajendra Nayak
2011-12-05 7:19 ` Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 4/4] regulator: map consumer regulator based on device tree Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
2011-11-18 11:17 ` Rajendra Nayak
[not found] ` <1321615040-13257-5-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2011-11-23 18:44 ` Mark Brown
2011-11-23 18:44 ` Mark Brown
2011-11-23 18:44 ` Mark Brown
2011-11-23 19:01 ` [PATCH v5 0/4] Device tree support for regulators Mark Brown
2011-11-23 19:01 ` Mark Brown
2011-11-23 19:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120523174803.GA18609@codeaurora.org \
--to=davidb@codeaurora.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=patches@linaro.org \
--cc=rnayak@ti.com \
--cc=robherring2@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.