Re: [PATCH v8 1/3] MTD: at91: extract hw ecc initialization to one function

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 16:05 Thu 24 May     , Josh Wu wrote:
> 
> On 5/23/2012 5:51 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >On 15:47 Wed 23 May     , Josh Wu wrote:
> >>Signed-off-by: Hong Xu<hong.xu@atmel.com>
> >>Signed-off-by: Josh Wu<josh.wu@atmel.com>
> >>---
> >>  drivers/mtd/nand/atmel_nand.c     |  147 ++++++++++++++++++++-----------------
> >>  drivers/mtd/nand/atmel_nand_ecc.h |    8 +-
> >>  2 files changed, 85 insertions(+), 70 deletions(-)
> >>
> >>diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> >>index 2165576..9723702 100644
> >>--- a/drivers/mtd/nand/atmel_nand.c
> >>+++ b/drivers/mtd/nand/atmel_nand.c
> >>@@ -42,20 +42,15 @@
> >>
> >>  #include<mach/cpu.h>
> >>
> >>+/* Hardware ECC registers */
> >>+#include "atmel_nand_ecc.h"
> >>+
> >>  static int use_dma = 1;
> >>  module_param(use_dma, int, 0);
> >>
> >>  static int on_flash_bbt = 0;
> >>  module_param(on_flash_bbt, int, 0);
> >>
> >>-/* Register access macros */
> >>-#define ecc_readl(add, reg)				\
> >>-	__raw_readl(add + ATMEL_ECC_##reg)
> >>-#define ecc_writel(add, reg, value)			\
> >>-	__raw_writel((value), add + ATMEL_ECC_##reg)
> >>-
> >>-#include "atmel_nand_ecc.h"	/* Hardware ECC registers */
> >>-
> >>  /* oob layout for large page size
> >>   * bad block info is on bytes 0 and 1
> >>   * the bytes have to be consecutives to avoid
> >>@@ -523,6 +518,75 @@ static int __devinit atmel_of_init_port(struct atmel_nand_host *host,
> >>  }
> >>  #endif
> >>
> >>+static int __init atmel_hw_nand_init_params(struct platform_device *pdev,
> >>+					 struct atmel_nand_host *host)
> >>+{
> >>+	struct resource		*regs;
> >>+	struct mtd_info		*mtd;
> >>+	struct nand_chip	*nand_chip;
> >>+
> >>+	nand_chip =&host->nand_chip;
> >>+	mtd =&host->mtd;
> >>+
> >>+	nand_chip->ecc.mode = NAND_ECC_SOFT;
> >>+	regs = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> >>+	if (!regs) {
> >>+		dev_err(host->dev,
> >>+			"Can't get I/O resource regs, use software ECC\n");
> >just return 0 and avoid the if else
> 
> sure. I'll fix it.
> 
> >
> >Best Regards,
> >J.
> 
> And I have same question about the relaxed version of read/write device.
> 
> this source code file still use __raw_readl/writel(), I think I can
> convert it all to relaxed version, except that the ECC control reset
> should use NO relaxed version.
> so the patch to convert it will look like following:
fine by me but put a comment about it

Best Regards,
J.