[GIT PULL 0/1] perf/core fix

[GIT PULL 0/1] perf/core fix

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://github.com/acmel/linux.git perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (1):
  perf hists: Fix recalculation of total_period when sorting entries

 tools/perf/util/hist.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Re: [GIT PULL 0/1] perf/core fix

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://github.com/acmel/linux.git perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (1):
>   perf hists: Fix recalculation of total_period when sorting entries
> 
>  tools/perf/util/hist.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Pulled, thanks Arnaldo!

	Ingo

[GIT PULL 0/1] perf/core fix

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please pull,

- Arnaldo

The following changes since commit ab0cce560ef177bdc7a8f73e9962be9d829a7b2c:

  Revert "sched, perf: Use a single callback into the scheduler" (2012-05-23 17:40:51 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core

for you to fetch changes up to a1d44b9acdf7b2820ef762846150b4d13b84e075:

  perf evlist: Explicititely initialize input_name (2012-05-23 21:47:51 -0300)

----------------------------------------------------------------
Fix perf evlist uninitialized local variable

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf evlist: Explicititely initialize input_name

 tools/perf/builtin-evlist.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/1] perf evlist: Explicititely initialize input_name

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

It was a global variable, so it was initialized, implicitely, to zero by
being placed in the bss.

Now it is just a local variable that is then passed to the __cmd_evlist
routine, so it must be explicitely set to NULL.

The problem manifested on a Fedora 17 system, using:

 gcc version 4.7.0 20120507 (Red Hat 4.7.0-5) (GCC)

But not on several other systems, by luck.

Reported-by: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-5e8wolcjs3rgd5i6yi995gfh@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-evlist.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-evlist.c b/tools/perf/builtin-evlist.c
index e52d77e..acd78dc 100644
--- a/tools/perf/builtin-evlist.c
+++ b/tools/perf/builtin-evlist.c
@@ -116,7 +116,7 @@ static const char * const evlist_usage[] = {
 int cmd_evlist(int argc, const char **argv, const char *prefix __used)
 {
 	struct perf_attr_details details = { .verbose = false, };
-	const char *input_name;
+	const char *input_name = NULL;
 	const struct option options[] = {
 		OPT_STRING('i', "input", &input_name, "file",
 			    "Input file name"),
-- 
1.7.9.2.358.g22243

Re: [GIT PULL 0/1] perf/core fix

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
> 	Please pull,
> 
> - Arnaldo
> 
> The following changes since commit ab0cce560ef177bdc7a8f73e9962be9d829a7b2c:
> 
>   Revert "sched, perf: Use a single callback into the scheduler" (2012-05-23 17:40:51 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core
> 
> for you to fetch changes up to a1d44b9acdf7b2820ef762846150b4d13b84e075:
> 
>   perf evlist: Explicititely initialize input_name (2012-05-23 21:47:51 -0300)
> 
> ----------------------------------------------------------------
> Fix perf evlist uninitialized local variable
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf evlist: Explicititely initialize input_name
> 
>  tools/perf/builtin-evlist.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pulled, thanks Arnaldo!

	Ingo