From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Airlie <airlied@linux.ie>
Cc: Dave Airlie <airlied@redhat.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] drm/udl: unlock before returning in udl_gem_mmap()
Date: Thu, 24 May 2012 10:59:26 +0000 [thread overview]
Message-ID: <20120524110041.GR4629@mwanda> (raw)
In-Reply-To: <20120322063056.GB7369@elgon.mountain>
On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote:
> If we hit an error here, then we should unlock and unreference obj
> before returning.
>
This is still present in linux-next.
regards,
dan carpenter
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index 852642d..6de6130 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
>
> ret = udl_gem_get_pages(gobj, GFP_KERNEL);
> if (ret)
> - return ret;
> + goto out;
> if (!gobj->base.map_list.map) {
> ret = drm_gem_create_mmap_offset(obj);
> if (ret)
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Airlie <airlied@linux.ie>
Cc: Dave Airlie <airlied@redhat.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] drm/udl: unlock before returning in udl_gem_mmap()
Date: Thu, 24 May 2012 14:00:41 +0300 [thread overview]
Message-ID: <20120524110041.GR4629@mwanda> (raw)
In-Reply-To: <20120322063056.GB7369@elgon.mountain>
On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote:
> If we hit an error here, then we should unlock and unreference obj
> before returning.
>
This is still present in linux-next.
regards,
dan carpenter
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index 852642d..6de6130 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
>
> ret = udl_gem_get_pages(gobj, GFP_KERNEL);
> if (ret)
> - return ret;
> + goto out;
> if (!gobj->base.map_list.map) {
> ret = drm_gem_create_mmap_offset(obj);
> if (ret)
next prev parent reply other threads:[~2012-05-24 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 6:30 [patch] drm/udl: unlock before returning in udl_gem_mmap() Dan Carpenter
2012-03-22 6:30 ` Dan Carpenter
2012-05-24 10:59 ` Dan Carpenter [this message]
2012-05-24 11:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524110041.GR4629@mwanda \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.