All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index()
Date: Fri, 25 May 2012 21:54:51 +0200	[thread overview]
Message-ID: <201205252154.51438.michael@walle.cc> (raw)
In-Reply-To: <CANr=Z=Yo_wooTxVWLPycg65Q=DOxKr-BcdAYjXvnCmSAj6T9yQ@mail.gmail.com>

Am Freitag 25 Mai 2012, 20:50:09 schrieb Joe Hershberger:
[..snip..]
> That way you aren't adding a function that noone else uses and you
> don't need a silly guard around it.

Hi Joe,

thanks for the review. I think i'll drop the dynamic "ethernet variable name" 
support entirely. Two reasons:
 - it isn't really dynamic, eg. the function always evaluates the name to
   "ethaddr"
 - back then when i wrote the support for the board the name was "eth1addr"
   and mike suggested to use the by index function for the getter and a new
   function for the setter. But i guess its not worth the hassle ;)

btw, imho your solution introduces a discrepancy between the setter and 
getter. i hope it doesnt bother you if i don't adapt your solution. But thanks 
for the work.

-- 
Michael

  reply	other threads:[~2012-05-25 19:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 22:50 [U-Boot] [PATCH v5 0/5] Kirkwood: add lschlv2 and lsxhl board support Michael Walle
2012-05-11 22:50 ` [U-Boot] [PATCH v5 1/5] lib: add rand() function Michael Walle
2012-05-23 16:34   ` Michael Walle
2012-05-24  4:32     ` Prafulla Wadaskar
2012-05-24 10:34       ` Michael Walle
2012-05-11 22:50 ` [U-Boot] [PATCH v5 2/5] net: add helper to generate random mac address Michael Walle
2012-05-25 17:52   ` Joe Hershberger
2012-05-11 22:50 ` [U-Boot] [PATCH v5 3/5] net: fix potential compiler warning Michael Walle
2012-05-16  1:11   ` Joe Hershberger
2012-05-11 22:50 ` [U-Boot] [PATCH v5 4/5] net: add eth_setenv_enetaddr_by_index() Michael Walle
2012-05-11 22:53   ` Michael Walle
2012-05-16  0:56   ` Joe Hershberger
2012-05-17 20:43     ` Michael Walle
2012-05-25 18:50       ` Joe Hershberger
2012-05-25 19:54         ` Michael Walle [this message]
2012-05-25 20:50           ` Joe Hershberger
2012-05-22 21:18     ` Michael Walle
2012-05-22 21:41       ` Rob Herring
2012-05-22 21:53         ` Michael Walle
2012-05-11 22:50 ` [U-Boot] [PATCH v5 5/5] Kirkwood: add lschlv2 and lsxhl board support Michael Walle
2012-05-22 20:58   ` Michael Walle
2012-05-24  4:50     ` Prafulla Wadaskar
2012-05-24  7:24   ` Prafulla Wadaskar
2012-05-24 10:30     ` Michael Walle
2012-05-25 23:34     ` Michael Walle
2012-05-25 14:13 ` [U-Boot] [PATCH v5 0/5] " Prafulla Wadaskar
2012-05-25 16:05   ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205252154.51438.michael@walle.cc \
    --to=michael@walle.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.