From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] of: release node fix for of_parse_phandle_with_args
Date: Fri, 25 May 2012 18:09:57 -0600 [thread overview]
Message-ID: <20120526000957.ED6BD3E13EF@localhost> (raw)
In-Reply-To: <1337952980-14621-3-git-send-email-b29396@freescale.com>
On Fri, 25 May 2012 21:36:17 +0800, Dong Aisheng <b29396@freescale.com> wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> Since this API requires user to call of_node_put for the node
> it returned via outargs, if no outargs provided, user have no
> chance to release it, so release it internally if no outargs
> provided.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
Applied, thanks.
g.
> ---
> drivers/of/base.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d9bfd49..91c1fb4 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -961,6 +961,8 @@ int of_parse_phandle_with_args(struct device_node *np, const char *list_name,
> out_args->args_count = count;
> for (i = 0; i < count; i++)
> out_args->args[i] = be32_to_cpup(list++);
> + } else {
> + of_node_put(node);
> }
> return 0;
> }
> --
> 1.7.0.4
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com, swarren@wwwdotorg.org,
devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
b29396@freescale.com
Subject: Re: [PATCH v4 3/6] of: release node fix for of_parse_phandle_with_args
Date: Fri, 25 May 2012 18:09:57 -0600 [thread overview]
Message-ID: <20120526000957.ED6BD3E13EF@localhost> (raw)
In-Reply-To: <1337952980-14621-3-git-send-email-b29396@freescale.com>
On Fri, 25 May 2012 21:36:17 +0800, Dong Aisheng <b29396@freescale.com> wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> Since this API requires user to call of_node_put for the node
> it returned via outargs, if no outargs provided, user have no
> chance to release it, so release it internally if no outargs
> provided.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
Applied, thanks.
g.
> ---
> drivers/of/base.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d9bfd49..91c1fb4 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -961,6 +961,8 @@ int of_parse_phandle_with_args(struct device_node *np, const char *list_name,
> out_args->args_count = count;
> for (i = 0; i < count; i++)
> out_args->args[i] = be32_to_cpup(list++);
> + } else {
> + of_node_put(node);
> }
> return 0;
> }
> --
> 1.7.0.4
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Dong Aisheng <b29396@freescale.com>, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linus.walleij@stericsson.com, swarren@wwwdotorg.org,
devicetree-discuss@lists.ozlabs.org, rob.herring@calxeda.com,
b29396@freescale.com
Subject: Re: [PATCH v4 3/6] of: release node fix for of_parse_phandle_with_args
Date: Fri, 25 May 2012 18:09:57 -0600 [thread overview]
Message-ID: <20120526000957.ED6BD3E13EF@localhost> (raw)
In-Reply-To: <1337952980-14621-3-git-send-email-b29396@freescale.com>
On Fri, 25 May 2012 21:36:17 +0800, Dong Aisheng <b29396@freescale.com> wrote:
> From: Dong Aisheng <dong.aisheng@linaro.org>
>
> Since this API requires user to call of_node_put for the node
> it returned via outargs, if no outargs provided, user have no
> chance to release it, so release it internally if no outargs
> provided.
>
> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
Applied, thanks.
g.
> ---
> drivers/of/base.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d9bfd49..91c1fb4 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -961,6 +961,8 @@ int of_parse_phandle_with_args(struct device_node *np, const char *list_name,
> out_args->args_count = count;
> for (i = 0; i < count; i++)
> out_args->args[i] = be32_to_cpup(list++);
> + } else {
> + of_node_put(node);
> }
> return 0;
> }
> --
> 1.7.0.4
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-05-26 0:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 13:36 [PATCH v4 1/6] gpio: fix a typo of comment message Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` [PATCH v4 2/6] gpio: re-add of_node_to_gpiochip function Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-26 0:01 ` Grant Likely
2012-05-26 0:01 ` Grant Likely
2012-05-26 0:01 ` Grant Likely
2012-05-26 16:15 ` Dong Aisheng
2012-05-26 16:15 ` Dong Aisheng
2012-05-25 13:36 ` [PATCH v4 3/6] of: release node fix for of_parse_phandle_with_args Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-26 0:09 ` Grant Likely [this message]
2012-05-26 0:09 ` Grant Likely
2012-05-26 0:09 ` Grant Likely
2012-05-25 13:36 ` [PATCH v4 4/6] gpio: introduce lock mechanism for gpiochip_find Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-26 0:25 ` Grant Likely
2012-05-26 0:25 ` Grant Likely
2012-05-26 0:25 ` Grant Likely
2012-05-26 16:17 ` Dong Aisheng
2012-05-26 16:17 ` Dong Aisheng
2012-05-30 4:10 ` Dong Aisheng
2012-05-30 4:10 ` Dong Aisheng
2012-05-30 6:33 ` Grant Likely
2012-05-30 6:33 ` Grant Likely
2012-05-25 13:36 ` [PATCH v4 5/6] of: add of_parse_phandle_with_args_ext function Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 16:50 ` Stephen Warren
2012-05-25 16:50 ` Stephen Warren
2012-05-25 13:36 ` [PATCH v4 6/6] pinctrl: add pinctrl gpio binding support Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 13:36 ` Dong Aisheng
2012-05-25 17:03 ` Stephen Warren
2012-05-25 17:03 ` Stephen Warren
2012-05-25 17:03 ` Stephen Warren
2012-05-26 16:52 ` Dong Aisheng
2012-05-26 16:52 ` Dong Aisheng
2012-05-26 16:52 ` Dong Aisheng
2012-05-27 15:39 ` Stephen Warren
2012-05-27 15:39 ` Stephen Warren
2012-05-30 3:01 ` Dong Aisheng
2012-05-30 3:01 ` Dong Aisheng
2012-05-30 3:52 ` Stephen Warren
2012-05-30 3:52 ` Stephen Warren
2012-05-30 6:35 ` Grant Likely
2012-05-30 6:35 ` Grant Likely
2012-05-26 0:29 ` Grant Likely
2012-05-26 0:29 ` Grant Likely
2012-05-26 0:29 ` Grant Likely
2012-05-26 16:58 ` Dong Aisheng
2012-05-26 16:58 ` Dong Aisheng
2012-05-30 6:46 ` Grant Likely
2012-05-30 6:46 ` Grant Likely
2012-05-30 6:46 ` Grant Likely
2012-05-30 7:29 ` Dong Aisheng
2012-05-30 7:29 ` Dong Aisheng
2012-05-25 23:57 ` [PATCH v4 1/6] gpio: fix a typo of comment message Grant Likely
2012-05-25 23:57 ` Grant Likely
2012-05-25 23:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120526000957.ED6BD3E13EF@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.