From: Alessandro Rubini <rubini@gnudd.com>
To: linux@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com,
alan@linux.intel.com, x86@kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 6/6] serial: add amba-pl011-pci
Date: Sat, 26 May 2012 11:27:12 +0200 [thread overview]
Message-ID: <20120526092712.GA4092@mail.gnudd.com> (raw)
In-Reply-To: <20120526084328.GE24149@n2100.arm.linux.org.uk>
>> + default y if STA2X11
>
> I don't think we want to encourage an ever growing list of platforms
> here. If we did this on ARM, this would be hellishly long.
Ok.
> NAK. We have interfaces in the AMBA code for dynamically allocating
> AMBA devices now - please use them instead of coding your own. They
> avoid bugs.
Sure. Thanks for noting. Maybe it wasn't there when I coded this
initially. Will do.
>> + printk(KERN_INFO "%s %i\n", __func__, __LINE__);
>
> This looks like debugging.
Yes. After sending I noted this and another point. I apologize.
Version 2 will be fixed in all respects.
> This comes nowhere close to being sane with the driver model. [...]
> In other words, save off the platform data pointer, unregister the struct
> device, and then free the platform data (it will not be used at that point.)
Thanks a lot for this and also the comments on APB/AHB in the other message.
/alessandro
WARNING: multiple messages have this Message-ID (diff)
From: rubini@gnudd.com (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] serial: add amba-pl011-pci
Date: Sat, 26 May 2012 11:27:12 +0200 [thread overview]
Message-ID: <20120526092712.GA4092@mail.gnudd.com> (raw)
In-Reply-To: <20120526084328.GE24149@n2100.arm.linux.org.uk>
>> + default y if STA2X11
>
> I don't think we want to encourage an ever growing list of platforms
> here. If we did this on ARM, this would be hellishly long.
Ok.
> NAK. We have interfaces in the AMBA code for dynamically allocating
> AMBA devices now - please use them instead of coding your own. They
> avoid bugs.
Sure. Thanks for noting. Maybe it wasn't there when I coded this
initially. Will do.
>> + printk(KERN_INFO "%s %i\n", __func__, __LINE__);
>
> This looks like debugging.
Yes. After sending I noted this and another point. I apologize.
Version 2 will be fixed in all respects.
> This comes nowhere close to being sane with the driver model. [...]
> In other words, save off the platform data pointer, unregister the struct
> device, and then free the platform data (it will not be used at that point.)
Thanks a lot for this and also the comments on APB/AHB in the other message.
/alessandro
next prev parent reply other threads:[~2012-05-26 9:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 15:47 [PATCH 0/6] Bridging PCI to amba Alessandro Rubini
2012-05-25 15:47 ` Alessandro Rubini
2012-05-25 15:48 ` [PATCH 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-25 15:48 ` [PATCH 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-26 8:33 ` Russell King - ARM Linux
2012-05-26 8:33 ` Russell King - ARM Linux
2012-05-25 15:48 ` [PATCH 3/6] ARM: " Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-25 15:48 ` [PATCH 4/6] pl011: " Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-25 15:48 ` [PATCH 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-25 15:48 ` [PATCH 6/6] serial: add amba-pl011-pci Alessandro Rubini
2012-05-25 15:48 ` Alessandro Rubini
2012-05-26 7:39 ` Arnd Bergmann
2012-05-26 7:39 ` Arnd Bergmann
2012-05-26 7:58 ` Alessandro Rubini
2012-05-26 7:58 ` Alessandro Rubini
2012-05-26 8:29 ` Arnd Bergmann
2012-05-26 8:29 ` Arnd Bergmann
2012-05-26 8:43 ` Russell King - ARM Linux
2012-05-26 8:43 ` Russell King - ARM Linux
2012-05-26 9:27 ` Alessandro Rubini [this message]
2012-05-26 9:27 ` Alessandro Rubini
2012-05-26 8:48 ` Russell King - ARM Linux
2012-05-26 8:48 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120526092712.GA4092@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=giancarlo.asnaghi@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.