From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Kirkwood: declare mpp config static and const
Date: Mon, 28 May 2012 23:45:25 +0200 [thread overview]
Message-ID: <201205282345.25035.michael@walle.cc> (raw)
In-Reply-To: <20120527212029.GA15012@w500.iskon.local>
Hi Luka,
Am Sonntag 27 Mai 2012, 23:20:29 schrieb Luka Perkov:
> NACK. At least in this version. Please double check all the kirkwood
> boards (taken from boards.cfg):
ups sorry, actually my tree wasn't up to date :( pogo_e02 is missing, too.
> diff --git a/board/raidsonic/ib62x0/ib62x0.c
> b/board/raidsonic/ib62x0/ib62x0.c index 65f2c2e..f888901 100644
> --- a/board/raidsonic/ib62x0/ib62x0.c
> +++ b/board/raidsonic/ib62x0/ib62x0.c
> @@ -42,7 +42,7 @@ int board_early_init_f(void)
> IB62x0_OE_LOW, IB62x0_OE_HIGH);
>
> /* Multi-Purpose Pins Functionality configuration */
> - u32 kwmpp_config[] = {
> + static const kwmpp_config[] = {
this should be static const u32 kwmpp_config[] = {
> Also you should note that this patch should be applied after your
> patches for lsxl board.
ah yes, thanks.
--
Michael
next prev parent reply other threads:[~2012-05-28 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 0:27 [U-Boot] [PATCH] Kirkwood: declare mpp config static and const Michael Walle
2012-05-27 21:20 ` Luka Perkov
2012-05-28 21:45 ` Michael Walle [this message]
2012-05-28 9:48 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205282345.25035.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.