From: Dan Carpenter <dan.carpenter@oracle.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] video: bfin_adv7393fb: Fix cleanup code
Date: Tue, 29 May 2012 06:21:07 +0000 [thread overview]
Message-ID: <20120529062107.GA21008@mwanda> (raw)
In-Reply-To: <1338224091-8322-1-git-send-email-emilgoode@gmail.com>
On Mon, May 28, 2012 at 06:54:51PM +0200, Emil Goode wrote:
> This patch fixes the cleanup code of the bfin_adv7393_fb_probe
> function.
>
> 1) The resources were not freed in the order that we allocated them
> so we call dma_free_coherent() before it was allocated.
> 2) The labels weren't in the right place which also meant that we
> freed resources that weren't allocated.
> 3) We should free gpio_free(P_IDENT(P_PPI0_FS3)) before returning.
> 4) Lets change the label names into something more meaningful.
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
Yep. Looks great.
I see the goto free_ppi_pins; I look up a couple lines. I see that
yeah, it makes sense to free the ppi_pins. I hit the '*' key in vim
I see that the label does exactly what it says. Move on.
Bing. Bang. Boom.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] video: bfin_adv7393fb: Fix cleanup code
Date: Tue, 29 May 2012 09:21:07 +0300 [thread overview]
Message-ID: <20120529062107.GA21008@mwanda> (raw)
In-Reply-To: <1338224091-8322-1-git-send-email-emilgoode@gmail.com>
On Mon, May 28, 2012 at 06:54:51PM +0200, Emil Goode wrote:
> This patch fixes the cleanup code of the bfin_adv7393_fb_probe
> function.
>
> 1) The resources were not freed in the order that we allocated them
> so we call dma_free_coherent() before it was allocated.
> 2) The labels weren't in the right place which also meant that we
> freed resources that weren't allocated.
> 3) We should free gpio_free(P_IDENT(P_PPI0_FS3)) before returning.
> 4) Lets change the label names into something more meaningful.
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
Yep. Looks great.
I see the goto free_ppi_pins; I look up a couple lines. I see that
yeah, it makes sense to free the ppi_pins. I hit the '*' key in vim
I see that the label does exactly what it says. Move on.
Bing. Bang. Boom.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-29 6:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 16:54 [PATCH v2] video: bfin_adv7393fb: Fix cleanup code Emil Goode
2012-05-28 16:54 ` Emil Goode
2012-05-29 6:21 ` Dan Carpenter [this message]
2012-05-29 6:21 ` Dan Carpenter
2012-05-29 15:07 ` Florian Tobias Schandinat
2012-05-29 15:07 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529062107.GA21008@mwanda \
--to=dan.carpenter@oracle.com \
--cc=FlorianSchandinat@gmx.de \
--cc=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.