All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Tao Ma <tm@tao.ma>, Eric Sandeen <sandeen@redhat.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Protect group inode free counting with group lock.
Date: Tue, 29 May 2012 08:39:50 -0400	[thread overview]
Message-ID: <20120529123950.GC16351@thunk.org> (raw)
In-Reply-To: <8932CA1F-B08D-4327-AD23-38EA56D49F47@dilger.ca>

On Mon, May 28, 2012 at 11:57:59PM -0600, Andreas Dilger wrote:
> > We are just disabling the uninit_bg so as to let the block group
> > initialization happen in the mkfs time. I don't know why the checksum is
> > also disabled by ^uninit_bg.
> 
> The checksum is controlled by uninit_bg, because there was a need to
> ensure the bg_itable_unused count and the UNINIT flags could be
> trusted when doing an e2fsck.
> 
> If you don't want to do lazy inode table initialization, that is
> disabled by "mke2fs -E lazy_itable_init=0".

You can also disable whether or not lazy inode table initialization
happens by default via /etc/mke2fs.conf.  At work we have a very
fairly havily modified /etc/mke2fs.conf which has our
production-specific mke2fs parameters defined, so that someone who
runs mke2fs by hand will get the same result at as the automated
systems.

I can easily see how if you are trying for predictable latency
numbers, disabling lazy inode table initialization makes a huge amount
of sense.  I'd recommend doing it via /etc/mke2fs.conf, though.

Regards,

						- Ted


  reply	other threads:[~2012-05-29 12:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16  8:49 [PATCH] ext4: Protect group inode free counting with group lock Tao Ma
2012-05-16 13:43 ` Eric Sandeen
2012-05-16 14:55   ` Tao Ma
2012-05-16 15:49     ` Eric Sandeen
2012-05-17  2:17       ` Tao Ma
2012-05-17  3:14         ` Eric Sandeen
2012-05-28 22:22         ` Ted Ts'o
2012-05-29  2:18           ` Tao Ma
2012-05-29  5:57             ` Andreas Dilger
2012-05-29 12:39               ` Ted Ts'o [this message]
2012-05-29 14:28                 ` Tao Ma
2012-05-16 14:58 ` Andreas Dilger
2012-05-16 15:10   ` Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120529123950.GC16351@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.