From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
mingo@elte.hu, tglx@linutronix.de, konrad.wilk@oracle.com,
jeremy@goop.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com, stable@vger.kernel.org
Subject: Re: [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems
Date: Wed, 30 May 2012 17:05:20 +0200 [thread overview]
Message-ID: <20120530150520.GC15438@x1.osrc.amd.com> (raw)
In-Reply-To: <4FC6363F.3040208@zytor.com>
On Wed, May 30, 2012 at 08:01:19AM -0700, H. Peter Anvin wrote:
> >> I'm not following: If the AMD variants (putting a special value into
> >> %edi) can be freely replaced by the non-AMD variants, why did
> >> the AMD special ones get used in the first place?
>
> > Older CPUs (K8) needed the AMD variants, starting with family 10h we
> > can use the normal versions.
>
> So no, not correct.
I don't see what the problem is: the amd* variants shouldn't have been
used at all in the first place. Fullstop. The patch should've been doing
*msrl_safe from the get-go. Regardless of family.
So what's the issue?
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-05-30 15:05 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 13:10 [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Andre Przywara
2012-05-30 13:33 ` [Xen-devel] " Jan Beulich
2012-05-30 13:33 ` Jan Beulich
2012-05-30 14:02 ` [Xen-devel] " Andre Przywara
2012-05-30 14:02 ` Andre Przywara
2012-05-30 14:23 ` [Xen-devel] " Jan Beulich
2012-05-30 14:23 ` Jan Beulich
2012-05-30 14:42 ` [Xen-devel] " H. Peter Anvin
2012-05-30 14:49 ` Konrad Rzeszutek Wilk
2012-05-30 15:12 ` Borislav Petkov
2012-05-30 15:40 ` Jan Beulich
2012-05-30 15:40 ` Jan Beulich
2012-05-30 15:45 ` H. Peter Anvin
2012-05-30 15:58 ` Borislav Petkov
2012-05-30 14:48 ` Jacob Shin
2012-05-30 14:48 ` Jacob Shin
2012-05-30 14:50 ` Konrad Rzeszutek Wilk
2012-05-30 15:03 ` Jacob Shin
2012-05-30 15:03 ` Jacob Shin
2012-05-30 17:17 ` Konrad Rzeszutek Wilk
2012-05-30 17:31 ` H. Peter Anvin
2012-05-30 22:23 ` Konrad Rzeszutek Wilk
2012-05-30 23:23 ` [tip:x86/urgent] x86, amd, xen: Avoid NULL pointer paravirt references tip-bot for Konrad Rzeszutek Wilk
2012-05-30 17:32 ` [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Borislav Petkov
2012-05-30 17:47 ` [PATCH] x86, AMD: Fix " Borislav Petkov
2012-05-30 17:47 ` [Xen-devel] [PATCH] x86/amd: fix " H. Peter Anvin
2012-05-30 17:51 ` Borislav Petkov
2012-05-30 18:00 ` H. Peter Anvin
2012-05-30 18:17 ` Borislav Petkov
2012-05-30 18:19 ` Borislav Petkov
2012-05-30 18:21 ` H. Peter Anvin
2012-05-30 18:29 ` Borislav Petkov
2012-05-30 18:20 ` H. Peter Anvin
2012-05-30 22:33 ` Konrad Rzeszutek Wilk
2012-05-30 23:09 ` H. Peter Anvin
2012-06-06 9:27 ` Ingo Molnar
2012-06-06 9:42 ` Borislav Petkov
2012-06-06 9:45 ` Ingo Molnar
2012-05-31 12:24 ` Andre Przywara
2012-05-31 12:24 ` Andre Przywara
2012-05-31 15:27 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-31 7:39 ` Jan Beulich
2012-05-31 7:39 ` Jan Beulich
2012-05-31 16:55 ` Borislav Petkov
2012-05-31 7:17 ` Jan Beulich
2012-05-31 7:17 ` Jan Beulich
2012-05-31 15:59 ` H. Peter Anvin
2012-05-30 14:39 ` Konrad Rzeszutek Wilk
2012-05-30 14:50 ` H. Peter Anvin
2012-05-30 14:51 ` Konrad Rzeszutek Wilk
2012-05-30 15:08 ` Jan Beulich
2012-05-30 15:08 ` Jan Beulich
2012-05-30 15:15 ` H. Peter Anvin
2012-05-30 15:35 ` Jan Beulich
2012-05-30 15:35 ` Jan Beulich
2012-05-30 16:48 ` Konrad Rzeszutek Wilk
2012-05-30 14:42 ` H. Peter Anvin
2012-05-30 14:55 ` Borislav Petkov
2012-05-30 14:58 ` H. Peter Anvin
2012-05-30 15:00 ` Borislav Petkov
2012-05-30 15:01 ` H. Peter Anvin
2012-05-30 15:05 ` Borislav Petkov [this message]
2012-05-30 23:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530150520.GC15438@x1.osrc.amd.com \
--to=bp@alien8.de \
--cc=andre.przywara@amd.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.