From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andre Przywara <andre.przywara@amd.com>,
Jacob Shin <Jacob.Shin@amd.com>,
mingo@elte.hu, jeremy@goop.org, tglx@linutronix.de,
xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems
Date: Wed, 30 May 2012 07:42:56 -0700 [thread overview]
Message-ID: <4FC631F0.9080109@zytor.com> (raw)
In-Reply-To: <4FC649790200007800086E51@nat28.tlf.novell.com>
On 05/30/2012 07:23 AM, Jan Beulich wrote:
>
> I see - the Xen code blindly overwrites pv_cpu_ops, despite not
> having initialized all members. That's an obvious oversight of the
> patch that introduced the _regs variants.
>
> Plus having secondary instances of things like rdmsrl_amd_safe()
> in asm/paravirt.h seems pretty strange an approach (which was
> why initially I didn't spot how a crash could happen there) - only
> the lowest level functions should get re-implemented here.
>
This kinds of things are part of why Xen makes me want to cry regularly.
-hpa
next prev parent reply other threads:[~2012-05-30 14:43 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 13:10 [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Andre Przywara
2012-05-30 13:33 ` [Xen-devel] " Jan Beulich
2012-05-30 13:33 ` Jan Beulich
2012-05-30 14:02 ` [Xen-devel] " Andre Przywara
2012-05-30 14:02 ` Andre Przywara
2012-05-30 14:23 ` [Xen-devel] " Jan Beulich
2012-05-30 14:23 ` Jan Beulich
2012-05-30 14:42 ` H. Peter Anvin [this message]
2012-05-30 14:49 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-30 15:12 ` Borislav Petkov
2012-05-30 15:40 ` Jan Beulich
2012-05-30 15:40 ` Jan Beulich
2012-05-30 15:45 ` H. Peter Anvin
2012-05-30 15:58 ` Borislav Petkov
2012-05-30 14:48 ` Jacob Shin
2012-05-30 14:48 ` Jacob Shin
2012-05-30 14:50 ` Konrad Rzeszutek Wilk
2012-05-30 15:03 ` Jacob Shin
2012-05-30 15:03 ` Jacob Shin
2012-05-30 17:17 ` Konrad Rzeszutek Wilk
2012-05-30 17:31 ` H. Peter Anvin
2012-05-30 22:23 ` Konrad Rzeszutek Wilk
2012-05-30 23:23 ` [tip:x86/urgent] x86, amd, xen: Avoid NULL pointer paravirt references tip-bot for Konrad Rzeszutek Wilk
2012-05-30 17:32 ` [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems Borislav Petkov
2012-05-30 17:47 ` [PATCH] x86, AMD: Fix " Borislav Petkov
2012-05-30 17:47 ` [Xen-devel] [PATCH] x86/amd: fix " H. Peter Anvin
2012-05-30 17:51 ` Borislav Petkov
2012-05-30 18:00 ` H. Peter Anvin
2012-05-30 18:17 ` Borislav Petkov
2012-05-30 18:19 ` Borislav Petkov
2012-05-30 18:21 ` H. Peter Anvin
2012-05-30 18:29 ` Borislav Petkov
2012-05-30 18:20 ` H. Peter Anvin
2012-05-30 22:33 ` Konrad Rzeszutek Wilk
2012-05-30 23:09 ` H. Peter Anvin
2012-06-06 9:27 ` Ingo Molnar
2012-06-06 9:42 ` Borislav Petkov
2012-06-06 9:45 ` Ingo Molnar
2012-05-31 12:24 ` Andre Przywara
2012-05-31 12:24 ` Andre Przywara
2012-05-31 15:27 ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-05-31 7:39 ` Jan Beulich
2012-05-31 7:39 ` Jan Beulich
2012-05-31 16:55 ` Borislav Petkov
2012-05-31 7:17 ` Jan Beulich
2012-05-31 7:17 ` Jan Beulich
2012-05-31 15:59 ` H. Peter Anvin
2012-05-30 14:39 ` Konrad Rzeszutek Wilk
2012-05-30 14:50 ` H. Peter Anvin
2012-05-30 14:51 ` Konrad Rzeszutek Wilk
2012-05-30 15:08 ` Jan Beulich
2012-05-30 15:08 ` Jan Beulich
2012-05-30 15:15 ` H. Peter Anvin
2012-05-30 15:35 ` Jan Beulich
2012-05-30 15:35 ` Jan Beulich
2012-05-30 16:48 ` Konrad Rzeszutek Wilk
2012-05-30 14:42 ` H. Peter Anvin
2012-05-30 14:55 ` Borislav Petkov
2012-05-30 14:58 ` H. Peter Anvin
2012-05-30 15:00 ` Borislav Petkov
2012-05-30 15:01 ` H. Peter Anvin
2012-05-30 15:05 ` Borislav Petkov
2012-05-30 23:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC631F0.9080109@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=Jacob.Shin@amd.com \
--cc=andre.przywara@amd.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.