From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <david.daney@cavium.com>
Cc: "Steven J. Hill" <sjhill@mips.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.
Date: Wed, 30 May 2012 22:01:41 +0100 [thread overview]
Message-ID: <20120530210141.GH30086@linux-mips.org> (raw)
In-Reply-To: <4FC6628F.9060807@cavium.com>
On Wed, May 30, 2012 at 11:10:23AM -0700, David Daney wrote:
> On 05/24/2012 01:38 PM, Steven J. Hill wrote:
> >From: "Steven J. Hill"<sjhill@mips.com>
> >
> >Remove usage of the '__attribute__((alias("...")))' hack that aliased
> >to integer arrays containing micro-assembled instructions. This hack
> >breaks when building a microMIPS kernel. It also makes the code much
> >easier to understand.
> >
> >Signed-off-by: Steven J. Hill<sjhill@mips.com>
>
> Looks good to (and even works for) me:
>
> Acked-by: David Daney <david.daney@cavium.com>
I have to admit that the attribute hack was a desperate attempt at
avoiding the last bit of assembler code for the page functions. But somehow
the patch isn't quite ripe yet. Building malta_defconfig from
7a3434a78b36be2d398a46fb505a3196a9df4a60 with this patch applied on top
I'm getting:
MODPOST 413 modules
ERROR: "copy_page" [fs/fuse/fuse.ko] undefined!
ERROR: "clear_page" [fs/fuse/fuse.ko] undefined!
ERROR: "clear_page" [drivers/net/ethernet/toshiba/tc35815.ko] undefined!
Ralf
next prev parent reply other threads:[~2012-05-30 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 20:38 [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions Steven J. Hill
2012-05-30 18:10 ` David Daney
2012-05-30 21:01 ` Ralf Baechle [this message]
2012-05-30 21:27 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530210141.GH30086@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.