Re: [PATCH] MIPS: Refactor 'clear_page' and 'copy_page' functions.

[Ralf Baechle <ralf@linux-mips.org>]

On Wed, May 30, 2012 at 10:01:41PM +0100, Ralf Baechle wrote:

> > On 05/24/2012 01:38 PM, Steven J. Hill wrote:
> > >From: "Steven J. Hill"<sjhill@mips.com>
> > >
> > >Remove usage of the '__attribute__((alias("...")))' hack that aliased
> > >to integer arrays containing micro-assembled instructions. This hack
> > >breaks when building a microMIPS kernel. It also makes the code much
> > >easier to understand.
> > >
> > >Signed-off-by: Steven J. Hill<sjhill@mips.com>
> > 
> > Looks good to (and even works for) me:
> > 
> > Acked-by: David Daney <david.daney@cavium.com>
> 
> I have to admit that the attribute hack was a desperate attempt at
> avoiding the last bit of assembler code for the page functions.  But somehow
> the patch isn't quite ripe yet.  Building malta_defconfig from
> 7a3434a78b36be2d398a46fb505a3196a9df4a60 with this patch applied on top
> I'm getting:
> 
>   MODPOST 413 modules
> ERROR: "copy_page" [fs/fuse/fuse.ko] undefined!
> ERROR: "clear_page" [fs/fuse/fuse.ko] undefined!
> ERROR: "clear_page" [drivers/net/ethernet/toshiba/tc35815.ko] undefined!

And with that fixed (trivial) I'm getting:

  AS      arch/mips/mm/page-funcs.o
arch/mips/mm/page-funcs.S: Assembler messages:
arch/mips/mm/page-funcs.S:29: Warning: .end symbol does not match .ent symbol.
arch/mips/mm/page-funcs.S:48: Warning: .end symbol does not match .ent symbol.
{standard input}: Error: .size expression for clear_page does not evaluate to a constant
{standard input}: Error: .size expression for copy_page does not evaluate to a constant

  Ralf