From: Andi Kleen <andi@firstfloor.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Johannes Goetzfried"
<Johannes.Goetzfried@informatik.stud.uni-erlangen.de>,
"Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
"Tilo Müller" <Tilo.Mueller@informatik.uni-erlangen.de>
Subject: Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation
Date: Wed, 30 May 2012 23:55:37 +0200 [thread overview]
Message-ID: <20120530215537.GA27374@one.firstfloor.org> (raw)
In-Reply-To: <20120530214448.GA15031@gondor.apana.org.au>
On Thu, May 31, 2012 at 07:44:48AM +1000, Herbert Xu wrote:
> On Wed, May 30, 2012 at 11:40:06PM +0200, Andi Kleen wrote:
> >
> > > What we could do is to use the cpuid-based probing when an algorithm
> > > is needed to selectively load the relevant implementations instead
> > > of all of them. However, for most algorithms it won't make that
> > > big a difference since all the available ones will be loaded anyway.
> >
> > Yes cpuid probing does that.
>
> I was under the impression that using cpuid meant that the algorithm
> would be loaded regardless of whether it has been requested, as long
> as the cpuid matches.
It loads it always correct.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Johannes Goetzfried"
<Johannes.Goetzfried@informatik.stud.uni-erlangen.de>,
"Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
"Tilo Müller" <Tilo.Mueller@informatik.uni-erlangen.de>
Subject: Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation
Date: Wed, 30 May 2012 23:55:37 +0200 [thread overview]
Message-ID: <20120530215537.GA27374@one.firstfloor.org> (raw)
In-Reply-To: <20120530214448.GA15031@gondor.apana.org.au>
On Thu, May 31, 2012 at 07:44:48AM +1000, Herbert Xu wrote:
> On Wed, May 30, 2012 at 11:40:06PM +0200, Andi Kleen wrote:
> >
> > > What we could do is to use the cpuid-based probing when an algorithm
> > > is needed to selectively load the relevant implementations instead
> > > of all of them. However, for most algorithms it won't make that
> > > big a difference since all the available ones will be loaded anyway.
> >
> > Yes cpuid probing does that.
>
> I was under the impression that using cpuid meant that the algorithm
> would be loaded regardless of whether it has been requested, as long
> as the cpuid matches.
It loads it always correct.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-05-30 21:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 14:51 [PATCH] crypto: serpent - add x86_64/avx assembler implementation Johannes Goetzfried
2012-05-27 14:51 ` Johannes Goetzfried
2012-05-28 6:37 ` Jussi Kivilinna
2012-05-28 6:37 ` Jussi Kivilinna
2012-05-28 14:10 ` Johannes Goetzfried
2012-05-28 21:33 ` Jussi Kivilinna
2012-05-30 2:27 ` Andi Kleen
2012-05-30 2:27 ` Andi Kleen
2012-05-30 7:30 ` Jussi Kivilinna
2012-05-30 7:30 ` Jussi Kivilinna
2012-05-30 11:32 ` Johannes Goetzfried
2012-05-30 15:39 ` Andi Kleen
2012-05-30 17:36 ` Johannes Goetzfried
2012-05-30 18:53 ` Jussi Kivilinna
2012-06-09 14:50 ` [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64 Jussi Kivilinna
2012-06-09 14:50 ` Jussi Kivilinna
2012-06-12 8:26 ` Herbert Xu
2012-06-12 8:26 ` Herbert Xu
2012-06-12 18:25 ` Jussi Kivilinna
2012-06-12 18:25 ` Jussi Kivilinna
2012-06-18 9:02 ` Herbert Xu
2012-06-18 9:02 ` Herbert Xu
2012-06-20 11:49 ` Jussi Kivilinna
2012-06-20 11:49 ` Jussi Kivilinna
2012-05-30 21:29 ` [PATCH] crypto: serpent - add x86_64/avx assembler implementation Herbert Xu
2012-05-30 21:29 ` Herbert Xu
2012-05-30 21:40 ` Andi Kleen
2012-05-30 21:40 ` Andi Kleen
2012-05-30 21:44 ` Herbert Xu
2012-05-30 21:44 ` Herbert Xu
2012-05-30 21:55 ` Andi Kleen [this message]
2012-05-30 21:55 ` Andi Kleen
2012-05-30 22:34 ` Herbert Xu
2012-05-30 22:34 ` Herbert Xu
2012-05-30 11:36 ` Johannes Goetzfried
2012-05-30 16:26 ` Andi Kleen
2012-05-30 17:49 ` Johannes Goetzfried
-- strict thread matches above, loose matches on Subject: below --
2012-05-28 14:12 Johannes Goetzfried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530215537.GA27374@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Johannes.Goetzfried@informatik.stud.uni-erlangen.de \
--cc=Tilo.Mueller@informatik.uni-erlangen.de \
--cc=herbert@gondor.apana.org.au \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.