From: Yong Zhang <yong.zhang0@gmail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Nicolas Pitre <nico@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH] ARM: cmpxchg: define __HAVE_ARCH_CMPXCHG for armv6 and later
Date: Thu, 31 May 2012 20:50:12 +0800 [thread overview]
Message-ID: <20120531125012.GA3741@zhy> (raw)
In-Reply-To: <20120531012450.GA8506@mudshark.cambridge.arm.com>
On Thu, May 31, 2012 at 02:24:50AM +0100, Will Deacon wrote:
> Hello,
>
> On Wed, May 30, 2012 at 08:51:26AM +0100, Yong Zhang wrote:
> > diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h
> > index 7eb18c1..a91b44e 100644
> > --- a/arch/arm/include/asm/cmpxchg.h
> > +++ b/arch/arm/include/asm/cmpxchg.h
> > @@ -127,6 +127,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
> >
> > #else /* min ARCH >= ARMv6 */
> >
> > +#define __HAVE_ARCH_CMPXCHG 1
> > +
> > extern void __bad_cmpxchg(volatile void *ptr, int size);
>
> As long as this only requires 4-byte cmpxchg support then I think this is
> fine. It looks like that's currently the case, so:
Yes and thanks for review.
Yong
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Will
WARNING: multiple messages have this Message-ID (diff)
From: yong.zhang0@gmail.com (Yong Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: cmpxchg: define __HAVE_ARCH_CMPXCHG for armv6 and later
Date: Thu, 31 May 2012 20:50:12 +0800 [thread overview]
Message-ID: <20120531125012.GA3741@zhy> (raw)
In-Reply-To: <20120531012450.GA8506@mudshark.cambridge.arm.com>
On Thu, May 31, 2012 at 02:24:50AM +0100, Will Deacon wrote:
> Hello,
>
> On Wed, May 30, 2012 at 08:51:26AM +0100, Yong Zhang wrote:
> > diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h
> > index 7eb18c1..a91b44e 100644
> > --- a/arch/arm/include/asm/cmpxchg.h
> > +++ b/arch/arm/include/asm/cmpxchg.h
> > @@ -127,6 +127,8 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
> >
> > #else /* min ARCH >= ARMv6 */
> >
> > +#define __HAVE_ARCH_CMPXCHG 1
> > +
> > extern void __bad_cmpxchg(volatile void *ptr, int size);
>
> As long as this only requires 4-byte cmpxchg support then I think this is
> fine. It looks like that's currently the case, so:
Yes and thanks for review.
Yong
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Will
next prev parent reply other threads:[~2012-05-31 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 7:51 [RFC PATCH] ARM: cmpxchg: define __HAVE_ARCH_CMPXCHG for armv6 and later Yong Zhang
2012-05-30 7:51 ` Yong Zhang
2012-05-31 1:24 ` Will Deacon
2012-05-31 1:24 ` Will Deacon
2012-05-31 1:24 ` Will Deacon
2012-05-31 12:50 ` Yong Zhang [this message]
2012-05-31 12:50 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531125012.GA3741@zhy \
--to=yong.zhang0@gmail.com \
--cc=Catalin.Marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nico@linaro.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.