From: Raghavendra D Prabhu <raghu.prabhu13@gmail.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes
Date: Fri, 1 Jun 2012 11:37:02 +0530 [thread overview]
Message-ID: <20120601060702.GA3975@Xye.local> (raw)
In-Reply-To: <4FC83789.8010900@sandeen.net>
[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]
Hi,
* On Thu, May 31, 2012 at 10:31:21PM -0500, Eric Sandeen <sandeen@sandeen.net> wrote:
>On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
>> Hi,
>>
>> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
>>
>> while (!agi->agi_freecount) {
>> }
>>
>> is redundant when noroom=1 and okalloc=0.
>>
>> Also, xfs_ialloc_ag_alloc function in the loop calls
>> ============
>> if (mp->m_maxicount &&
>> mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
>>
>> ===============
>>
>> condition again.
>>
>> So I have moved xfs_tran_brelse etc. into the condition along with message.
>>
>> Is this logic valid? If it is, then I will look into rate-limiting the message etc.
>
>It'd be easiest to understand this new change as a patch rather than as a description.
Yeah, I would certainly send it as a patch. This was just for RFC. :)
>
>If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.
Thanks, I will make it so.
>
>Thanks,
>
>-eric
>
>_______________________________________________
>xfs mailing list
>xfs@oss.sgi.com
>http://oss.sgi.com/mailman/listinfo/xfs
>
Regards,
--
Raghavendra Prabhu
GPG Id : 0xD72BE977
Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
www: wnohang.net
[-- Attachment #1.2: Type: application/pgp-signature, Size: 490 bytes --]
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-01 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 0:37 [PATCH] Printk for ENOSPC due to lack of inodes Raghavendra D Prabhu
2012-03-07 17:39 ` Eric Sandeen
2012-05-31 19:36 ` Raghavendra D Prabhu
2012-06-01 3:31 ` Eric Sandeen
2012-06-01 6:07 ` Raghavendra D Prabhu [this message]
2012-06-05 6:46 ` Raghavendra D Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601060702.GA3975@Xye.local \
--to=raghu.prabhu13@gmail.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.