Re: [PATCH] Printk for ENOSPC due to lack of inodes

From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] Printk for ENOSPC due to lack of inodes
Date: Thu, 31 May 2012 22:31:21 -0500	[thread overview]
Message-ID: <4FC83789.8010900@sandeen.net> (raw)
In-Reply-To: <20120531193616.GA3953@Xye.local>

On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
> Hi,
> 
> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
> 
>     while (!agi->agi_freecount) {
>     }
> 
> is redundant when noroom=1 and okalloc=0.
> 
> Also, xfs_ialloc_ag_alloc function in the loop calls 
> ============
>     if (mp->m_maxicount &&
>         mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
> 
> ===============
> 
> condition again.
> 
> So I have moved xfs_tran_brelse etc. into the condition along with message.
> 
> Is this logic valid? If it is, then I will look into rate-limiting the message etc.

It'd be easiest to understand this new change as a patch rather than as a description.

If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.

Thanks,

-eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs