[PATCH] drivers/staging/line6/variax.c: Change some strict_strtoul() calls

[PATCH] drivers/staging/line6/variax.c: Change some strict_strtoul() calls

[Johannes Thumshirn]

Changed strict_strtoul() calls which do not result in a need to change
interfaces of called functions.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
---
 drivers/staging/line6/variax.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index d366222..efa496d 100644
--- a/drivers/staging/line6/variax.c
+++ b/drivers/staging/line6/variax.c
@@ -353,10 +353,10 @@ static ssize_t variax_set_model(struct device *dev,
 {
 	struct usb_line6_variax *variax =
 	    usb_get_intfdata(to_usb_interface(dev));
-	unsigned long value;
+	u8 value;
 	int ret;
 
-	ret = strict_strtoul(buf, 10, &value);
+	ret = kstrtou8(buf, 10, &value);
 	if (ret)
 		return ret;
 
@@ -387,10 +387,10 @@ static ssize_t variax_set_active(struct device *dev,
 {
 	struct usb_line6_variax *variax =
 	    usb_get_intfdata(to_usb_interface(dev));
-	unsigned long value;
+	u8 value;
 	int ret;
 
-	ret = strict_strtoul(buf, 10, &value);
+	ret = kstrtou8(buf, 10, &value);
 	if (ret)
 		return ret;
 
-- 
1.7.7.6

Re: [PATCH] drivers/staging/line6/variax.c: Change some strict_strtoul() calls

[morbid-rsa]

Just wanted to ask about the status of this patch.

On Sun, May 20, 2012 at 2:55 PM, Johannes Thumshirn
<morbidrsa@googlemail.com> wrote:
> Changed strict_strtoul() calls which do not result in a need to change
> interfaces of called functions.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
> ---
>  drivers/staging/line6/variax.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
> index d366222..efa496d 100644
> --- a/drivers/staging/line6/variax.c
> +++ b/drivers/staging/line6/variax.c
> @@ -353,10 +353,10 @@ static ssize_t variax_set_model(struct device *dev,
>  {
>        struct usb_line6_variax *variax =
>            usb_get_intfdata(to_usb_interface(dev));
> -       unsigned long value;
> +       u8 value;
>        int ret;
>
> -       ret = strict_strtoul(buf, 10, &value);
> +       ret = kstrtou8(buf, 10, &value);
>        if (ret)
>                return ret;
>
> @@ -387,10 +387,10 @@ static ssize_t variax_set_active(struct device *dev,
>  {
>        struct usb_line6_variax *variax =
>            usb_get_intfdata(to_usb_interface(dev));
> -       unsigned long value;
> +       u8 value;
>        int ret;
>
> -       ret = strict_strtoul(buf, 10, &value);
> +       ret = kstrtou8(buf, 10, &value);
>        if (ret)
>                return ret;
>
> --
> 1.7.7.6
>

Re: [PATCH] drivers/staging/line6/variax.c: Change some strict_strtoul() calls

[Greg KH]

On Sat, Jun 02, 2012 at 01:36:10PM +0200, morbid-rsa wrote:
> Just wanted to ask about the status of this patch.
> 
> On Sun, May 20, 2012 at 2:55 PM, Johannes Thumshirn
> <morbidrsa@googlemail.com> wrote:
> > Changed strict_strtoul() calls which do not result in a need to change
> > interfaces of called functions.
> >
> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
> > ---
> >  drivers/staging/line6/variax.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)

As this came in after the merge window closed for patches, I have to
hold on to it until 3.5-rc1 comes out.  It's in my queue and not lost,
don't worry.

thanks for your patience,

greg k-h

Re: [PATCH] drivers/staging/line6/variax.c: Change some strict_strtoul() calls

[morbid-rsa]

On Sat, Jun 2, 2012 at 1:56 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Jun 02, 2012 at 01:36:10PM +0200, morbid-rsa wrote:
>> Just wanted to ask about the status of this patch.
>>
>> On Sun, May 20, 2012 at 2:55 PM, Johannes Thumshirn
>> <morbidrsa@googlemail.com> wrote:
>> > Changed strict_strtoul() calls which do not result in a need to change
>> > interfaces of called functions.
>> >
>> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
>> > Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
>> > ---
>> >  drivers/staging/line6/variax.c |    8 ++++----
>> >  1 files changed, 4 insertions(+), 4 deletions(-)
>
> As this came in after the merge window closed for patches, I have to
> hold on to it until 3.5-rc1 comes out.  It's in my queue and not lost,
> don't worry.
>
> thanks for your patience,
>
> greg k-h

Oh ok, thanks for the fast answer.

Johannes