Re: linux-next: build failure after merge of the origin tree

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Paul Mundt <lethal@linux-sh.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: linux-next: build failure after merge of the origin tree
Date: Mon, 4 Jun 2012 16:39:33 +0900	[thread overview]
Message-ID: <20120604073932.GG11445@linux-sh.org> (raw)
In-Reply-To: <20120604125724.603f62215c9dc9269db898a2@canb.auug.org.au>

On Mon, Jun 04, 2012 at 12:57:24PM +1000, Stephen Rothwell wrote:
> Hi Al,
> 
> Building the origin tree (v3.5-rc1 sh lboxre2_defconfig and other sh
> configs) failed like this:
> 
> arch/sh/include/asm/thread_info.h:172:2: error: 'TAINT_WARN' undeclared (first use in this function)
> 
> Caused by commit edd63a2763bd ("set_restore_sigmask() is never called
> without SIGPENDING (and never should be)").  Missing include of kernel.h.
> 
Ideally bug.h should be including linux/kernel.h itself due to its
TAINT_WARN dependence, it just seems to be getting lucky on other
platforms who either don't have this combination or pull in kernel.h from
somewhere else.

That commit also introduces a linux/bug.h include for WARN_ON() in
linux/thread_info.h which would be similarly insufficient for any
TIF_RESTORE_SIGMASK && !HAVE_SET_RESTORE_SIGMASK platform that also uses
asm-generic/bug.h. 

Given that, I'd prefer stuffing the include in asm-generic directly:

---

bug.h: need linux/kernel.h for TAINT_WARN.

asm-generic/bug.h uses taint flags that are only defined in
linux/kernel.h, resulting in build failures on platforms that
don't include linux/kernel.h some other way:

	arch/sh/include/asm/thread_info.h:172:2: error: 'TAINT_WARN' undeclared (first use in this function)

Caused by commit edd63a2763bd ("set_restore_sigmask() is never called
without SIGPENDING (and never should be)").

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 2520a6e..9f02005 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -2,6 +2,7 @@
 #define _ASM_GENERIC_BUG_H
 
 #include <linux/compiler.h>
+#include <linux/kernel.h>
 
 #ifdef CONFIG_BUG

next prev parent reply	other threads:[~2012-06-04  7:39 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04  2:57 linux-next: build failure after merge of the origin tree Stephen Rothwell
2012-06-04  7:39 ` Paul Mundt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-12-18  4:13 Stephen Rothwell
2024-12-18  8:03 ` Jürgen Groß
2024-09-30  3:38 Stephen Rothwell
2024-09-30 10:28 ` Krzysztof Kozlowski
2024-09-30 10:50   ` Kent Overstreet
2024-09-30 11:00     ` Krzysztof Kozlowski
2023-06-30  2:59 Stephen Rothwell
2023-06-30  3:43 ` Linus Torvalds
2021-09-19 23:42 Stephen Rothwell
2021-09-14  0:08 Stephen Rothwell
2021-09-14  0:08 ` Stephen Rothwell
2021-09-14  0:19 ` Linus Torvalds
2021-09-14  0:19   ` Linus Torvalds
2021-09-14  0:24   ` Linus Torvalds
2021-09-14  0:24     ` Linus Torvalds
2021-09-14  0:58     ` Stephen Rothwell
2021-09-14  0:58       ` Stephen Rothwell
2021-09-14  1:29       ` Linus Torvalds
2021-09-14  1:29         ` Linus Torvalds
2021-09-14  1:37         ` Linus Torvalds
2021-09-14  1:37           ` Linus Torvalds
2021-09-14  2:03           ` Linus Torvalds
2021-09-14  2:03             ` Linus Torvalds
2021-09-14  2:08         ` Stephen Rothwell
2021-09-14  2:08           ` Stephen Rothwell
2021-09-14  2:12           ` Linus Torvalds
2021-09-14  2:12             ` Linus Torvalds
2021-09-14  2:50             ` Michael Ellerman
2021-09-14  2:50               ` Michael Ellerman
2021-09-14 12:21             ` Michael Ellerman
2021-09-14 12:21               ` Michael Ellerman
2021-09-14  2:39           ` Stephen Rothwell
2021-09-14  2:39             ` Stephen Rothwell
2021-09-07 23:07 Stephen Rothwell
2021-09-07 23:09 ` Stephen Rothwell
2021-09-07 23:17   ` Marco Elver
2021-09-07 23:38     ` Miguel Ojeda
2020-07-30 22:58 Stephen Rothwell
2020-07-30 22:58 ` Stephen Rothwell
2020-07-30 23:15 ` Stephen Rothwell
2020-07-30 23:15   ` Stephen Rothwell
2020-07-29 23:08 Stephen Rothwell
2020-07-29 23:43 ` Linus Torvalds
2020-07-30  0:09   ` Linus Torvalds
2020-07-30  2:12     ` Linus Torvalds
2020-07-30  2:30       ` Willy Tarreau
2020-07-30  3:17   ` Kees Cook
2020-07-30  3:22     ` Willy Tarreau
2020-07-30  6:14       ` Willy Tarreau
2020-07-30  9:59         ` Marc Zyngier
2020-07-30 10:09           ` Catalin Marinas
2020-07-30 15:00             ` Will Deacon
2020-07-30 17:49         ` Kees Cook
2020-07-30 18:24     ` Linus Torvalds
2020-07-30 18:47       ` Kees Cook
2020-06-04 22:37 Stephen Rothwell
2020-06-05  0:04 ` Josh Poimboeuf
2020-06-05  9:48   ` Jessica Yu
2020-04-20 10:23 Stephen Rothwell
2020-01-31  4:12 Stephen Rothwell
2020-01-31  4:17 ` Randy Dunlap
2020-01-31  9:39   ` Daniel Lezcano
2012-10-09 23:21 Stephen Rothwell
2012-10-09 23:21 ` Stephen Rothwell
2012-10-09 23:45 ` Andrew Morton
2012-10-09 23:45   ` Andrew Morton
2012-10-09 23:52   ` Yasuaki Ishimatsu
2012-10-09 23:52     ` Yasuaki Ishimatsu
2012-10-09 23:52     ` Yasuaki Ishimatsu
2012-10-10  3:12     ` Stephen Rothwell
2012-10-10  3:12       ` Stephen Rothwell
2012-10-10  3:12       ` Stephen Rothwell
2012-10-10  0:07   ` Stephen Rothwell
2012-10-10  0:07     ` Stephen Rothwell
2012-01-18 23:31 Stephen Rothwell
2012-01-19  8:21 ` Jens Axboe
2012-01-19  8:23   ` Jens Axboe
2011-11-06 23:12 Stephen Rothwell
2011-11-06 23:12 ` Stephen Rothwell
2011-11-07  1:52 ` David Miller
2011-11-07  2:47   ` Stephen Rothwell
2011-11-07  3:36     ` David Miller
2011-11-07  5:29       ` Kirsher, Jeffrey T
2011-11-07 16:46         ` Rose, Gregory V
2011-11-07 17:46           ` Rose, Gregory V
2011-11-07 17:46             ` Rose, Gregory V
2011-07-25  1:16 Stephen Rothwell

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:2520a6e dfblob:9f02005 )
 OR (
bs:"Re: linux-next: build failure after merge of the origin tree" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120604073932.GG11445@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.