From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP4: hwspinlocks_init() should be static
Date: Mon, 4 Jun 2012 00:40:23 -0700 [thread overview]
Message-ID: <20120604074022.GX12766@atomide.com> (raw)
In-Reply-To: <1336914919-20032-1-git-send-email-ohad@wizery.com>
* Ohad Ben-Cohen <ohad@wizery.com> [120513 06:19]:
> Sparse found out that hwspinlocks_init() wasn't marked static,
> and it should've been.
Looks like this already got fixed by Paul's commit 8c3d4534.
Regards,
Tony
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> arch/arm/mach-omap2/hwspinlock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
> index 454dfce..8763c85 100644
> --- a/arch/arm/mach-omap2/hwspinlock.c
> +++ b/arch/arm/mach-omap2/hwspinlock.c
> @@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
> .base_id = 0,
> };
>
> -int __init hwspinlocks_init(void)
> +static int __init hwspinlocks_init(void)
> {
> int retval = 0;
> struct omap_hwmod *oh;
> --
> 1.7.5.4
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: hwspinlocks_init() should be static
Date: Mon, 4 Jun 2012 00:40:23 -0700 [thread overview]
Message-ID: <20120604074022.GX12766@atomide.com> (raw)
In-Reply-To: <1336914919-20032-1-git-send-email-ohad@wizery.com>
* Ohad Ben-Cohen <ohad@wizery.com> [120513 06:19]:
> Sparse found out that hwspinlocks_init() wasn't marked static,
> and it should've been.
Looks like this already got fixed by Paul's commit 8c3d4534.
Regards,
Tony
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> arch/arm/mach-omap2/hwspinlock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c
> index 454dfce..8763c85 100644
> --- a/arch/arm/mach-omap2/hwspinlock.c
> +++ b/arch/arm/mach-omap2/hwspinlock.c
> @@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
> .base_id = 0,
> };
>
> -int __init hwspinlocks_init(void)
> +static int __init hwspinlocks_init(void)
> {
> int retval = 0;
> struct omap_hwmod *oh;
> --
> 1.7.5.4
>
next prev parent reply other threads:[~2012-06-04 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 13:15 [PATCH] ARM: OMAP4: hwspinlocks_init() should be static Ohad Ben-Cohen
2012-05-13 13:15 ` Ohad Ben-Cohen
2012-06-04 7:40 ` Tony Lindgren [this message]
2012-06-04 7:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604074022.GX12766@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.