From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Consolidate bootcount code into drivers/bootcount
Date: Mon, 4 Jun 2012 15:14:17 +0200 [thread overview]
Message-ID: <201206041514.17201.sr@denx.de> (raw)
In-Reply-To: <4FCCB21F.3080504@gmail.com>
On Monday 04 June 2012 15:03:27 Rob Herring wrote:
> On 06/04/2012 07:38 AM, Stefan Roese wrote:
> > This patch moves all bootcount implementations into a common
> > directory: drivers/bootcount. The generic bootcount driver
> > is now usable not only by powerpc platforms, but others as well.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> > Cc: Christian Riesch <christian.riesch@omicron.at>
> > Cc: Manfred Rudigier <manfred.rudigier@omicron.at>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Reinhard Meyer <reinhard.meyer@emk-elektronik.de>
> > ---
> > v2:
> > - Added CONFIG_BOOTCOUNT_LE to bootcount_davinci.c and enabled it
> >
> > in calimain.h to select little-endian accessors.
>
> highbank is also LE.
Yes, sure. I could move those inline functions to a header, so that they can
be used by the other "drivers" as well. Okay?
> Why don't you use __BYTE_ORDER rather than a new
> define?
Unfortunately not. There are LE platforms that use BE accessors for the
bootcounter already (Davinci enbw_cmc). Mostly historical reasons I assume,
since the original bootcount implementation was powerpc specific with those
be32() functions.
Thanks,
Stefan
next prev parent reply other threads:[~2012-06-04 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 12:38 [U-Boot] [PATCH v2] Consolidate bootcount code into drivers/bootcount Stefan Roese
2012-06-04 12:55 ` Valentin Longchamp
2012-06-04 13:03 ` Rob Herring
2012-06-04 13:14 ` Stefan Roese [this message]
2012-06-04 13:30 ` Christian Riesch
2012-07-10 7:09 ` Wolfgang Denk
2012-06-04 13:42 ` Stefan Roese
2012-06-04 13:39 ` Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206041514.17201.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.